End-to-end automation test for reindexing #1751 #2489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
…h Guide #2494 Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
- Update BasicDate.json to support code vs valueString - Improve Test Coverage for ReindexOperation Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
lmsurpre
reviewed
Jun 14, 2021
lmsurpre
reviewed
Jun 14, 2021
lmsurpre
reviewed
Jun 14, 2021
lmsurpre
reviewed
Jun 14, 2021
| @@ -98,7 +98,7 @@ | |||
| "_start": { | |||
| "extension": [{ | |||
| "url": "http://hl7.org/fhir/StructureDefinition/data-absent-reason", | |||
| "valueString": "masked" | |||
| "valueCode": "masked" | |||
There was a problem hiding this comment.
is this fix needed for any tests, or just a general cleanup thing? just checking since we currently point to the released fhir-examples.
There was a problem hiding this comment.
I have to update, otherwise I have to exclude it when I post to the server, which rejects it as invalid (no-value) data-absent-reason
lmsurpre
reviewed
Jun 14, 2021
...server-test/src/test/java/com/ibm/fhir/server/test/operation/ReindexOperationPhase2Test.java
Outdated
Show resolved
Hide resolved
lmsurpre
reviewed
Jun 14, 2021
...server-test/src/test/java/com/ibm/fhir/server/test/operation/ReindexOperationPhase3Test.java
Outdated
Show resolved
Hide resolved
lmsurpre
reviewed
Jun 14, 2021
lmsurpre
reviewed
Jun 14, 2021
...on/fhir-operation-reindex/src/main/java/com/ibm/fhir/operation/reindex/ReindexOperation.java
Show resolved
Hide resolved
lmsurpre
reviewed
Jun 14, 2021
...on/fhir-operation-reindex/src/main/java/com/ibm/fhir/operation/reindex/ReindexOperation.java
Outdated
Show resolved
Hide resolved
…eration/reindex/ReindexOperation.java Signed-off-by: Paul Bastide <pbastide@us.ibm.com> Co-authored-by: Lee Surprenant <lmsurpre@us.ibm.com>
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
in FHIROperationRegistry Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
tbieste
reviewed
Jun 14, 2021
...server-test/src/test/java/com/ibm/fhir/server/test/operation/ReindexOperationPhase1Test.java
Outdated
Show resolved
Hide resolved
...server-test/src/test/java/com/ibm/fhir/server/test/operation/ReindexOperationPhase2Test.java
Outdated
Show resolved
Hide resolved
...on/fhir-operation-reindex/src/main/java/com/ibm/fhir/operation/reindex/ReindexOperation.java
Outdated
Show resolved
Hide resolved
...on/fhir-operation-reindex/src/main/java/com/ibm/fhir/operation/reindex/ReindexOperation.java
Show resolved
Hide resolved
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
tbieste
approved these changes
Jun 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses:
1 - Hardening the Reindex Operation to bad input and reflective responses
2 - Update the documentation to include an omitted input parameter
3 - Add Reindex workflow with three jobs (in the matrix) - db2, postgres, derby
4 - Add multiple phase tests which require restarts between them
5 - BasicDate.json had a small error using valueString instead of code
6 - Added LogicalResource and Type level for the ReindexOperation
7 - Cleaned up the FHIROperationRegistry to register at system, type and instance level
What's not included:
1 - Reindex after Migration (a separate PR, based on these integration tests, will address the tests)
Signed-off-by: Paul Bastide pbastide@us.ibm.com