FHIRClient.getWebTarget(String baseURL) throws NPE #2450 #2452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
JohnTimm
reviewed
Jun 2, 2021
- Code Review with John - Changed construction to be in constructor instead of in getClient() - Added/updated test.oauth2.properties to read from special file instead of custom injection - Refactored to remove unused getBasicAuth Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
tbieste
reviewed
Jun 2, 2021
fhir-server-test/src/test/java/com/ibm/fhir/client/test/FHIRClientTestBase.java
Outdated
Show resolved
Hide resolved
…ientTestBase.java Signed-off-by: Paul Bastide <pbastide@us.ibm.com> Co-authored-by: Troy Biesterfeld <60481063+tbieste@users.noreply.github.com>
tbieste
pushed a commit
that referenced
this pull request
Jun 9, 2021
FHIRClient.getWebTarget(String baseURL) throws NPE #2450
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Paul Bastide pbastide@us.ibm.com