-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issue #2284 - support skippable updates for batch/transaction methods #2295
Conversation
61cc2d7
to
59e6347
Compare
If `X-FHIR-UPDATE-IF-MODIFIED` is set to true on the request, then all updates (including patches) will be processed in accordance with this update optimization. Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
if (parentNode == null) { | ||
throw new FHIRPatchException("Unable to compute the parent for '" + elementName + "';" + | ||
" a FHIRPathPatch replace FHIRPath must select a node with a parent", fhirPath); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a somewhat unrelated change that might merit its own separate issue, but i found this NPE bug when I added a patch test and got the patch wrong
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fhir-server-test/src/test/java/com/ibm/fhir/server/test/BundleTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
If
X-FHIR-UPDATE-IF-MODIFIED
is set to true on the request, then allupdates (including patches) in the bundle will be processed in accordance
with this update optimization.
Signed-off-by: Lee Surprenant lmsurpre@us.ibm.com