Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #2284 - support skippable updates for batch/transaction methods #2295

Merged
merged 2 commits into from
Apr 28, 2021

Conversation

lmsurpre
Copy link
Member

@lmsurpre lmsurpre commented Apr 28, 2021

If X-FHIR-UPDATE-IF-MODIFIED is set to true on the request, then all
updates (including patches) in the bundle will be processed in accordance
with this update optimization.

Signed-off-by: Lee Surprenant lmsurpre@us.ibm.com

@lmsurpre lmsurpre force-pushed the issue-2284 branch 2 times, most recently from 61cc2d7 to 59e6347 Compare April 28, 2021 03:41
If `X-FHIR-UPDATE-IF-MODIFIED` is set to true on the request, then all
updates (including patches) will be processed in accordance with this
update optimization.

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
@lmsurpre lmsurpre added this to the Sprint 2021-06 milestone Apr 28, 2021
Comment on lines +909 to +912
if (parentNode == null) {
throw new FHIRPatchException("Unable to compute the parent for '" + elementName + "';" +
" a FHIRPathPatch replace FHIRPath must select a node with a parent", fhirPath);
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a somewhat unrelated change that might merit its own separate issue, but i found this NPE bug when I added a patch test and got the patch wrong

@lmsurpre lmsurpre removed this from the Sprint 2021-06 milestone Apr 28, 2021
Copy link
Contributor

@michaelwschroeder michaelwschroeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from lee-main-2 to main April 28, 2021 13:28
Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
Copy link
Collaborator

@JohnTimm JohnTimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lmsurpre lmsurpre merged commit c62367e into main Apr 28, 2021
@lmsurpre lmsurpre deleted the issue-2284 branch April 28, 2021 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants