Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: it tests were not running for drug formulary and c4bb #1820

Merged
merged 1 commit into from
Dec 12, 2020
Merged

fix: it tests were not running for drug formulary and c4bb #1820

merged 1 commit into from
Dec 12, 2020

Conversation

prb112
Copy link
Contributor

@prb112 prb112 commented Dec 11, 2020

Signed-off-by: Paul Bastide pbastide@us.ibm.com

@prb112
fix: it tests were not running for drug formulary and c4bb
3f6e7ff 
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
@prb112 prb112 added the bug Something isn't working label Dec 11, 2020
@prb112 prb112 requested a review from lmsurpre December 11, 2020 22:11
@prb112 prb112 self-assigned this Dec 11, 2020
lmsurpre
lmsurpre approved these changes Dec 11, 2020
View reviewed changes
Copy link
Member

@lmsurpre lmsurpre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lmsurpre
Copy link
Member

lmsurpre commented Dec 11, 2020 •
edited
Loading

the changes look good, but what do we need to do to enable them to run in the CI? i didn't see anything here that would change that...

UPDATE: now I actually looked and I see the inclusion of the tests is dependent on their presence on the server (as determined by ProfilesTestBase.checkProfileExistsOnServer())...clever

@lmsurpre lmsurpre merged commit f0b6ac1 into issue-1542 Dec 12, 2020
@lmsurpre lmsurpre deleted the fix-it-tests-ig-version-change branch December 12, 2020 02:49
@prb112
Copy link
Contributor Author

prb112 commented Dec 12, 2020

the changes look good, but what do we need to do to enable them to run in the CI? i didn't see anything here that would change that...

UPDATE: now I actually looked and I see the inclusion of the tests is dependent on their presence on the server (as determined by ProfilesTestBase.checkProfileExistsOnServer())...clever

That's right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmsurpre lmsurpre lmsurpre approved these changes

Assignees

@prb112 prb112

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prb112 @lmsurpre