issue #1272 - simplify searchParameter configuration

[lmsurpre]

Initially we made each searchParameter its own object so that we could
add additional properties for issue #1351.
However, now we don't think that any additional fields are needed and so
we can simplify the config to be a simple map of SearchParameter code
-> SearchParameter.url

This format will give us the flexibility of overriding a SearchParameter
code for a given resource type for a given deploy. However, currently
the code from the config is not used...it will only use the url and it
will auto-resolve any conflicting codes.

Signed-off-by: Lee Surprenant lmsurpre@us.ibm.com

[prb112]

LGTM, per our conversation this looks right

[tbieste]

However, currently the code from the config is not used...it will only use the url and it
will auto-resolve any conflicting codes.

I wonder if for clarity/consistency if the "code" was required to match the "code" of the SearchParameter pointed to by the URL. Perhaps we should add that in a follow-on PR.

[lmsurpre]

I wonder if for clarity/consistency if the "code" was required to match the "code" of the SearchParameter pointed to by the URL. Perhaps we should add that in a follow-on PR.

Good thought. Eventually I don't want to require them to match because we want to enable overriding the one in the SearchParameter with the one in the config. However, since thats a bigger lift, I think its worth seeing if there's an easy way to add the validation check you describe to this PR. Looking...