-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issue #1351 - Check _include and _revinclude values are supported #1600
Conversation
fhir-search/src/main/java/com/ibm/fhir/search/util/SearchUtil.java
Outdated
Show resolved
Hide resolved
ef5bbbf
to
77a0bfd
Compare
77a0bfd
to
d88baae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tbieste is it possible for you to update the Capabilities resource to update the CapabilityStatement with these values from the config?
https://www.hl7.org/fhir/capabilitystatement-definitions.html#CapabilityStatement.rest.resource.searchInclude
and https://www.hl7.org/fhir/capabilitystatement-definitions.html#CapabilityStatement.rest.resource.searchRevInclude
fhir-search/src/main/java/com/ibm/fhir/search/exception/SearchExceptionUtil.java
Show resolved
Hide resolved
fhir-search/src/main/java/com/ibm/fhir/search/exception/SearchExceptionUtil.java
Show resolved
Hide resolved
fhir-search/src/main/java/com/ibm/fhir/search/util/SearchUtil.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
fhir-search/src/main/java/com/ibm/fhir/search/util/SearchUtil.java
Outdated
Show resolved
Hide resolved
fhir-search/src/test/java/com/ibm/fhir/search/parameters/SearchParameterRestrictionTest.java
Show resolved
Hide resolved
Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
d88baae
to
c7d9192
Compare
Sure, it looks like there's already logic in Capabilities.buildCapabilityStatement() that fills in some of the other rest.resource properties, so I can do that for searchInclude and searchRevInclude as well. |
Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Update the supported _include values, _revinclude values, and search parameter combinations to be configurable.
Signed-off-by: Troy Biesterfeld tbieste@us.ibm.com