Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #1351 - Check _include and _revinclude values are supported #1600

Merged
merged 4 commits into from
Oct 27, 2020

Conversation

tbieste
Copy link
Contributor

@tbieste tbieste commented Oct 19, 2020

Update the supported _include values, _revinclude values, and search parameter combinations to be configurable.

Signed-off-by: Troy Biesterfeld tbieste@us.ibm.com

@tbieste tbieste self-assigned this Oct 19, 2020
@tbieste tbieste force-pushed the tbieste-issue-1351 branch 6 times, most recently from ef5bbbf to 77a0bfd Compare October 20, 2020 19:38
@tbieste tbieste requested a review from lmsurpre October 20, 2020 20:04
@tbieste tbieste marked this pull request as ready for review October 20, 2020 20:04
@tbieste tbieste requested a review from prb112 October 20, 2020 20:04
@tbieste tbieste force-pushed the tbieste-issue-1351 branch from 77a0bfd to d88baae Compare October 20, 2020 20:28
Copy link
Member

@lmsurpre lmsurpre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
@tbieste tbieste force-pushed the tbieste-issue-1351 branch from d88baae to c7d9192 Compare October 26, 2020 16:50
@tbieste
Copy link
Contributor Author

tbieste commented Oct 26, 2020

@tbieste is it possible for you to update the Capabilities resource to update the CapabilityStatement with these values from the config?
https://www.hl7.org/fhir/capabilitystatement-definitions.html#CapabilityStatement.rest.resource.searchInclude
and https://www.hl7.org/fhir/capabilitystatement-definitions.html#CapabilityStatement.rest.resource.searchRevInclude

Sure, it looks like there's already logic in Capabilities.buildCapabilityStatement() that fills in some of the other rest.resource properties, so I can do that for searchInclude and searchRevInclude as well.

Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
@tbieste
Copy link
Contributor Author

tbieste commented Oct 26, 2020

Sure, it looks like there's already logic in Capabilities.buildCapabilityStatement() that fills in some of the other rest.resource properties, so I can do that for searchInclude and searchRevInclude as well.

Done.

Copy link
Contributor

@prb112 prb112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@lmsurpre lmsurpre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prb112 prb112 merged commit d8212bc into master Oct 27, 2020
@prb112 prb112 deleted the tbieste-issue-1351 branch October 27, 2020 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants