Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1113 - fhir-ig-carin-bb search tests #1159

Merged
merged 6 commits into from
May 28, 2020
Merged

Issue 1113 - fhir-ig-carin-bb search tests #1159

merged 6 commits into from
May 28, 2020

Conversation

prb112
Copy link
Contributor

@prb112 prb112 commented May 27, 2020

No description provided.

prb112 added 3 commits May 27, 2020 15:09


Signed-off-by: Paul Bastide <pbastide@us.ibm.com>


Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
@lmsurpre lmsurpre changed the title Issue 1113 Issue 1113 - fhir-ig-carin-bb search tests May 28, 2020

/*
* This class is not designed to run its own. The class does the basic lift to check:
* <li> is the profile valid to run on the server?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should there be another item in this list?

Copy link
Member

@lmsurpre lmsurpre May 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* <li> is the profile valid to run on the server?
* <li> is the profile valid to run on the server?
* <li> does the search response bundle contain the desired resource(s)?

Copy link
Member

@lmsurpre lmsurpre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prb112
Copy link
Contributor Author

prb112 commented May 28, 2020

Thank you merging, so i can get it in my postgres automation

@prb112 prb112 merged commit 7b6335f into master May 28, 2020
@prb112 prb112 deleted the issue-1113 branch May 28, 2020 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants