Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e windows tests report success even when e2e tests fail #698

Closed
lmsurpre opened this issue Feb 11, 2020 · 2 comments
Closed

e2e windows tests report success even when e2e tests fail #698

lmsurpre opened this issue Feb 11, 2020 · 2 comments
Assignees
@prb112
Labels
bug Something isn't working
Milestone
Sprint 9

Comments

@lmsurpre
Copy link
Member

Describe the bug
image

To Reproduce
Steps to reproduce the behavior:

  1. Introduce an e2e test failure and open a PR

Expected behavior
The e2e windows job should show a red X

Additional context
I was hoping it was as simple as adding $ErrorActionPreference = "Stop" to the github action, but it seems like that wasn't enough.
@lmsurpre lmsurpre added the bug Something isn't working label Feb 11, 2020
@prb112
Copy link
Contributor

prb112 commented Feb 11, 2020

@lmsurpre if you need me to build local, let me know, and leave a message

prb112 added a commit that referenced this issue Feb 28, 2020
@prb112
e2e windows tests report success even when e2e tests fail #698
4f3466d 
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
@prb112 prb112 self-assigned this Feb 28, 2020
@prb112 prb112 added this to the Sprint 9 milestone Feb 28, 2020
@prb112
Copy link
Contributor

prb112 commented Feb 28, 2020

tested in my fork... basically pushed Lee's fix into the script

prb112 added a commit that referenced this issue Mar 2, 2020
@prb112
e2e windows tests report success even when e2e tests fail #698
8d383fb 
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
prb112 added a commit that referenced this issue Mar 4, 2020
@prb112
e2e windows tests report success even when e2e tests fail #698
afa3e7c 
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
prb112 added a commit that referenced this issue Mar 4, 2020
@prb112
e2e windows tests report success even when e2e tests fail #698
8a98927 
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
prb112 added a commit that referenced this issue Mar 4, 2020
@prb112
Merge pull request #756 from IBM/issue-698
a66980d 
e2e windows tests report success even when e2e tests fail #698
@prb112 prb112 closed this as completed Mar 4, 2020
ccorley pushed a commit to ccorley/FHIR that referenced this issue Apr 21, 2020
@prb112
e2e windows tests report success even when e2e tests fail LinuxForHea…
baa36ba 
…lth#698

Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
Signed-off-by: ccorley <ccorley@us.ibm.com>
ccorley pushed a commit to ccorley/FHIR that referenced this issue Apr 21, 2020
@prb112
e2e windows tests report success even when e2e tests fail LinuxForHea…
c51aacf 
…lth#698

Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
Signed-off-by: ccorley <ccorley@us.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prb112 prb112

Labels
bug Something isn't working
Projects
None yet
Milestone
Sprint 9
Development

No branches or pull requests
2 participants
@prb112 @lmsurpre