Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to PDex PlanNet 1.1.0 #3650

Closed
lmsurpre opened this issue May 19, 2022 · 2 comments
Closed

Update to PDex PlanNet 1.1.0 #3650

lmsurpre opened this issue May 19, 2022 · 2 comments
Assignees
@lmsurpre
Labels
enhancement New feature or request

Comments

@lmsurpre
Copy link
Member

lmsurpre commented May 19, 2022 •
edited
Loading

Is your feature request related to a problem? Please describe.
PDex PlanNet 1.1.0 was published April 4, 2022 ... its time we add that to our fhir-ig-pdex-plan-net module.

Describe the solution you'd like
Add 1.1.0 alongside 1.0.0 ...similar to what we've done.

We should also move the corresponding examples from fhir-examples down to src/test/resources/examples/100 and add the new examples alongside those in a 110 directory.

Describe alternatives you've considered
Replace 1.0.0 with 1.1.0

Acceptance Criteria

  1. GIVEN the fhir-ig-davinci-pdex-plan-net jar is in userlib
    WHEN a resource is validated against an applicable profile with no version suffix (or specifies a version of 1.1.0)
    THEN validation uses the artifacts from PDex PlanNet 1.1.0

  2. GIVEN the fhir-ig-davinci-pdex-plan-net jar is in userlib
    WHEN a resource is validated against an applicable profile with a version id of 1.0.0
    THEN validation uses the artifacts from PDex PlanNet 1.0.0

Additional context
@lmsurpre lmsurpre added the enhancement New feature or request label May 19, 2022
@lmsurpre lmsurpre self-assigned this May 19, 2022
lmsurpre added a commit that referenced this issue May 20, 2022
@lmsurpre
issue #3650 - add the 1.1.0 files and move 1.0.0 examples
7b42341 
And update ResourceProcessor to pretty-print both the conformance files
and the examples.
I grouped all the "lots of files" changes into this commit.
I will make a separate commit for adding the RegistryResourceProvider
and any other code changes.

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue May 20, 2022
@lmsurpre
issue #3650 - add the 1.1.0 ResourceProvider and update tests
1070d59 
Also added version suffix to 1.0.0 canonical URLs to prevent 1.0.0
validation from using 1.1.0 profiles and value set.

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue May 20, 2022
@lmsurpre
issue #3650 - add the 1.1.0 ResourceProvider and update tests
e18cb40 
Also added version suffix to 1.0.0 canonical URLs to prevent 1.0.0
validation from using 1.1.0 profiles and value set.

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue May 20, 2022
@lmsurpre
issue #3650 - add the 1.1.0 ResourceProvider and update tests
e7fbe8b 
Also added version suffix to 1.0.0 canonical URLs to prevent 1.0.0
validation from using 1.1.0 profiles and value set.

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue May 24, 2022
@lmsurpre
issue #3650 - add the 1.1.0 files and move 1.0.0 examples
6bc54eb 
And update ResourceProcessor to pretty-print both the conformance files
and the examples.
I grouped all the "lots of files" changes into this commit.
I will make a separate commit for adding the RegistryResourceProvider
and any other code changes.

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue May 24, 2022
@lmsurpre
issue #3650 - add the 1.1.0 ResourceProvider and update tests
a1a12b8 
Also added version suffix to 1.0.0 canonical URLs to prevent 1.0.0
validation from using 1.1.0 profiles and value set.

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue May 24, 2022
@lmsurpre
issue #3650 - add the 1.1.0 files and move 1.0.0 examples
e822b54 
And update ResourceProcessor to pretty-print both the conformance files
and the examples.
I grouped all the "lots of files" changes into this commit.
I will make a separate commit for adding the RegistryResourceProvider
and any other code changes.

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue May 24, 2022
@lmsurpre
issue #3650 - add the 1.1.0 ResourceProvider and update tests
af2b923 
Also added version suffix to 1.0.0 canonical URLs to prevent 1.0.0
validation from using 1.1.0 profiles and value set.

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue May 27, 2022
@lmsurpre
issues #3641 #3650 #3652 - update docs
ef3afe7 
Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Jun 9, 2022
@lmsurpre
Merge pull request #3651 from IBM/issue-3650
1df15e0 
issue #3650 - add PDEX PlanNet 1.1.0
lmsurpre added a commit that referenced this issue Jun 9, 2022
@lmsurpre
Merge pull request #3666 from IBM/issue-3652-docs
3f471f0 
issues #3641 #3650 #3652 - update docs
@lmsurpre
Copy link
Member Author

lmsurpre commented Sep 2, 2022

We found that 1.0.0 profiles which reference extensions did not have their versions specified and so ended up being validated against the extension definitions from 1.1.0. Needs work.

lmsurpre added a commit that referenced this issue Sep 2, 2022
@lmsurpre
issue #3650 - specify target version for more 1.0.0 artifacts
45dafbc 
1. update StructureDefinition artifacts to specify that the plannet
extensions referenced from 1.0.0 profiles should be the 1.0.0 version of
the extension definitions

2. update StructureDefinition artifacts to specify that plannet code
systems referenced from 1.0.0 valuesets should be the 1.0.0 version of
those code systems

3. fix the ConstraintGeneratorTest to specify the version of artifacts
to generate constraints from (previously it would always use the
"latest" vesion, even for the test that was supposed to execute against
the 1.0.0 artifacts)

Signed-off-by: Lee Surprenant <lmsurpre@merative.com>
lmsurpre added a commit that referenced this issue Sep 7, 2022
@lmsurpre
Merge pull request #3938 from LinuxForHealth/issue-3650
70bff4f 
issue #3650 - specify target version for more 1.0.0 artifacts
@lmsurpre
Copy link
Member Author

lmsurpre commented Sep 7, 2022

Walked through the ConstraintGenerator output with Robin and Prasanna.
Also executed the ExamplesValidationTest from PDex PlanNet and confirmed both 1.0.0 and 1.1.0 examples are validating as expected.

@lmsurpre lmsurpre closed this as completed Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lmsurpre lmsurpre

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lmsurpre