Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle transaction processing should replace local references in resource ids, elements of type uri, url, oid, uuid, and <a href=“” & <img src=“” in the narrative. #2993

Open
michaelwschroeder opened this issue Nov 15, 2021 · 3 comments
Assignees

Comments

@michaelwschroeder
Copy link
Contributor

Is your feature request related to a problem? Please describe.
From https://www.hl7.org/fhir/http.html#trules

Servers SHALL replace all matching links in the bundle, whether they are found in the resource ids, resource references, elements of type uri, url, oid, uuid, and <a href=“” & <img src=“” in the narrative. Elements of type canonical are not replaced.

Today, the IBM FHIR Server only replaces local references in elements of type Reference. Local references should be replaced in all of the elements specified above.

Describe the solution you'd like
The IBM FHIR Server should replace all local references in resource ids, elements of type uri, url, oid, uuid, and <a href=“” & <img src=“” in the narrative.

Describe alternatives you've considered

Acceptance Criteria

  1. GIVEN a transaction bundle with resources A and B
    AND resource A is a POST
    AND resource B is a POST or PUT with a local reference to the fullUrl for resource A in a resource id, element of type uri, url, oid, uuid, or <a href=“” or <img src=“” tag in the narrative
    WHEN the bundle is posted to the server
    THEN the local reference in resource B is updated to the assigned resource id of resource A

Additional context
Add any other context or screenshots about the feature request here.

@lmsurpre
Copy link
Member

plan: Lee to open an HL7 JIRA issue and link to that from here.

@lmsurpre
Copy link
Member

lmsurpre commented Feb 28, 2022

I opened https://jira.hl7.org/browse/FHIR-36032

We should move this one to the icebox, but first we should at least make a comment in our Conformance.md that we're purposefully deviating from the spec on this one

lmsurpre added a commit that referenced this issue Feb 28, 2022
Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Feb 28, 2022
* issue #2993 - document reference replacement non-conformance

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>

* Update docs/src/pages/Conformance.md

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>

Co-authored-by: Troy Biesterfeld <tbieste@us.ibm.com>

Co-authored-by: Troy Biesterfeld <tbieste@us.ibm.com>
@lmsurpre
Copy link
Member

lmsurpre commented Mar 8, 2022

https://ibm.github.io/FHIR/Conformance now states:

One discrepency from the specification is that, during reference replacement, we do not replace string matches of the fullUrl within

elements of type uri, url, oid, uuid, and <a href="" & <img src="" in the narrative

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants