feat(#38): make module TurboModule-compatible #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- create JS Codegen spec - use install_modules_dependencies util in podspec if possible, to install React deps - migrate Android module class to conform to codegenerated spec when new arch enabled - copy codegen-ed to oldarch Android source set to make module work when new arch disabled - migrate iOS module class to conform to codegenerated spec when new arch enabled
|
Hi @LinusU , let me know if there's anything I'd need to improve in this PR |
|
@LinusU lgtm |
|
@mateusz1913 is the android newarch folder missing? |
|
@pinpong no, the codegen spec class is used by default and if old arch enabled, it uses the class from old arch folder |
818Nawaf
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #38
👋 This PR adds TurboModule support
List of changes: