Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problems with graphics #604

Merged
merged 4 commits into from
Jul 19, 2024
Merged

Fix problems with graphics #604

merged 4 commits into from
Jul 19, 2024

Conversation

khider
Copy link
Member

@khider khider commented Jul 19, 2024

This fixes two issues encountered with EnsembleSeries and EnsembleGeoSeries graphics:

  1. Issue plot_trace legend now shows the same name for all traces instead of just doing one #602 Changes to the Matplotlib API required to put a label with an underscore on the traces to avoid having a legend entry for everything since these are ignored. Another solution was found: passing the handles directly to legend; however this would result in the traces showing up again is another line was added to the plot.
  2. Issue Dashboard not respecting default plot colors #598 The code was lifted directly from the GeoSeries.dashboard resulting in self.archiveType being always None. Needed to set it to the archiveType in the first entry in the series_list.

@khider khider requested a review from alexkjames July 19, 2024 19:44
@alexkjames alexkjames merged commit 5ad1375 into master Jul 19, 2024
1 check passed
@alexkjames alexkjames deleted the graphics branch July 19, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants