Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ensembleseries doc build failure #596

Merged
merged 2 commits into from
Jul 3, 2024
Merged

Conversation

alexkjames
Copy link
Contributor

Fixes error in recent doc builds causing failure.

Lat and lon were being passed to a series object in the new from_PaleoEnsembleArray functions.

Also fixed wrong class usage in mulensegeoseries docstring

Copy link
Collaborator

@CommonClimate CommonClimate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for identifying the issue. Shouldn't L80 of mulensgeoseries.py say mul_ens = pyleo.MulEnsGeoSeries(ens_list) rather than mul_ens = pyleo.MulEnsGeoSeries([ts_ens])?

@alexkjames
Copy link
Contributor Author

Thanks for identifying the issue. Shouldn't L80 of mulensgeoseries.py say mul_ens = pyleo.MulEnsGeoSeries(ens_list) rather than mul_ens = pyleo.MulEnsGeoSeries([ts_ens])?

yes, just fixed, thanks for catching that!

@CommonClimate CommonClimate merged commit 98a1566 into master Jul 3, 2024
1 check passed
@CommonClimate CommonClimate deleted the mulens_doc_fix branch July 3, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants