Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/secret #91

Merged
merged 1 commit into from
Mar 28, 2023
Merged

fix/secret #91

merged 1 commit into from
Mar 28, 2023

Conversation

bitknox
Copy link
Collaborator

@bitknox bitknox commented Mar 28, 2023

Description

Loads the session secret from the environment instead of the default value.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@bitknox bitknox requested a review from Lindharden March 28, 2023 13:41
@bitknox bitknox changed the title Stop using default session secret fix/secret Mar 28, 2023
@sonarcloud
Copy link

sonarcloud bot commented Mar 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Mansin-ITU Mansin-ITU merged commit 451c82f into main Mar 28, 2023
@Mansin-ITU Mansin-ITU deleted the fix/secret branch March 28, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants