Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API for Simulation #25

Merged
merged 37 commits into from
Feb 24, 2023
Merged

API for Simulation #25

merged 37 commits into from
Feb 24, 2023

Conversation

nikso-itu
Copy link
Collaborator

@nikso-itu nikso-itu commented Feb 22, 2023 •
edited by bitknox
Loading

Description

Implements all endpoints that are required for the simulation.

Closes #13, implements #24, implements #18, implements #15, implements #16, implements #17

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

nikso-itu and others added 30 commits February 18, 2023 18:50
@nikso-itu
Added global field for storing latest request
3c154c1
@nikso-itu
Added route for /latest
86c6605
@nikso-itu
Save Register request
64f07a6
@nikso-itu
Controller for fetching latest request
2bbc04a
@nikso-itu
Save request directly as JSON
93ea80b
@nikso-itu
Added route for /msgs
2db9f5d
@nikso-itu
moved saveRequest to globals
918bf77
@nikso-itu
Use proper name for Latest
48ba80b
@nikso-itu
Added handler for getting messages as JSON
1f96dbd
@nikso-itu
Added route for msgs/username GET
f9a653d
@nikso-itu
Moved msg related handlers to seperate controller
d4eb29e
@nikso-itu
Message controller with GET messages from username
74d5f8a
@nikso-itu
Helper method for converting username to user id
3dcd0bc
@nikso-itu
merge simulation with release 3
f4652f8
@bitknox
Add MacOS specific files to gitignore
0afbf36
@bitknox
Create sim endpoint for the simulator routes
58628c4
@bitknox
Fix database path
684662f
@bitknox
Create simulator middleware
e3d5018
@bitknox
Return JSON values from message sim endpoints
17a9993
@bitknox
Implement latest endpoint
df28a57
@bitknox
Add deprecation warning on outdated GetUserId
9e869a1
@Lindharden @Mansin-ITU @bitknox
Feature: Sim Endpoint - /fllws/<username> #18
c6aa158 
Co-authored-by: beth <beth@itu.dk>
Co-authored-by: Johan Flensmark <jokf@itu.dk>
@nikso-itu
Started work on msgs/username POST
1c7b251
@nikso-itu
Merge branch 'feature/simulation' of https://github.com/Lindharden/De…
7868979 
…vOps into feature/simulation
@Lindharden @Mansin-ITU @bitknox
Feature: Sim Endpoint - /register #24
effcab9 
Co-authored-by: beth <beth@itu.dk>
Co-authored-by: Johan Flensmark <jokf@itu.dk>
@Lindharden
Merge branch 'feature/simulation' of https://github.com/Lindharden/De…
e962fa2 
…vOps into feature/simulation
@Lindharden @Mansin-ITU @bitknox
Fixed double registered handler
ac2cb7f 
Co-authored-by: beth <beth@itu.dk>
Co-authored-by: Johan Flensmark <jokf@itu.dk>
@nikso-itu
Moved filtered message to Model/SimulatorModel
7a7b655
@nikso-itu
Added model for message request
8b5fcdd
@nikso-itu
Implemented POST message handler #17 & move filter
c8ea931
@nikso-itu nikso-itu added the enhancement New feature or request label Feb 22, 2023
@nikso-itu nikso-itu added this to the Simulator start milestone Feb 22, 2023
This was linked to issues Feb 22, 2023
Feature: Sim Endpoint - /msgs #16
Closed
Feature: Sim Endpoint - /latest #15
Closed
Feature: Sim Endpoint - /msgs/<username> #17
Closed
Feature: Sim Endpoint - /fllws/<username> #18
Closed
Feature: Sim Endpoint - /register #24
Closed
bitknox
bitknox approved these changes Feb 23, 2023
View reviewed changes
Copy link
Collaborator

@bitknox bitknox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. Code has been tested with the test_sim_compliance.py script.

Mansin-ITU
Mansin-ITU approved these changes Feb 23, 2023
View reviewed changes
Copy link
Collaborator

@Mansin-ITU Mansin-ITU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Lindharden
Lindharden approved these changes Feb 24, 2023
View reviewed changes
Copy link
Owner

@Lindharden Lindharden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

controllers/messageController.go Outdated Show resolved Hide resolved
controllers/messageController.go Outdated Show resolved Hide resolved
controllers/messageController.go Outdated Show resolved Hide resolved
helpers/authenticationHelpers.go Show resolved Hide resolved
@Lindharden
Copy link
Owner

Lindharden commented Feb 24, 2023 •
edited
Loading

We should probably also (in the future) extract the simulator methods to a controller only responsible for simulation to ensure cohesion

bitknox and others added 3 commits February 24, 2023 10:05
@bitknox @Lindharden
Update controllers/messageController.go
f6ecfed 
Remove comment

Co-authored-by: Lindharden <jepli@itu.dk>
@bitknox @Lindharden
Update controllers/messageController.go
d8881eb 
Remove comment

Co-authored-by: Lindharden <jepli@itu.dk>
@bitknox @Lindharden
Update controllers/messageController.go
035bc09 
Remove comment

Co-authored-by: Lindharden <jepli@itu.dk>
@Lindharden Lindharden removed the request for review from a user February 24, 2023 09:18
@Lindharden Lindharden merged commit e72f677 into main Feb 24, 2023
@Lindharden Lindharden deleted the feature/simulation branch February 24, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bitknox bitknox bitknox approved these changes

@Lindharden Lindharden Lindharden approved these changes

@Mansin-ITU Mansin-ITU Mansin-ITU approved these changes

@KjellbergD KjellbergD KjellbergD approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Simulator start
5 participants
@nikso-itu @Lindharden @bitknox @Mansin-ITU @KjellbergD