Bind comment updates #262
Bind comment updates #262
Conversation
davidge20
requested review from
JustinCappos,
rennergade,
yashaswi2000,
Yaxuan-w,
qianxichen233,
ve1nard,
rupeshkoushik07 and
namanlalitnyu
There was a problem hiding this comment.
Overall, it's a good first pass. At a high level:
-
focus on why the code does something instead of what. For example, why did you insert an item into a data structure?
-
Feel free to say when you are not sure. This is totally normal and something I do when writing my own code. Don't be shy to do this more often.
-
if you want to cite a source go ahead. For example, if you read a manpage to understand something or looked at an article, it's okay to drop a link, especially if the concept is complicated. This might be helpful for some of the setsockopt activities and related flags.
|
Please ping me for a review after you've had a chance to address all the comments. |
|
@JustinCappos pinging for further review after updates |
Description
Commented out bind_syscall and all functions related to it