Skip to content

Commit

Permalink
Fix broken link, add newline to EOF (kubeflow#41)
Browse files Browse the repository at this point in the history
* Fix broken link, add newline to EOF

* Fix broken checkout.sh link
  • Loading branch information
texasmichelle authored and jlewi committed Feb 25, 2018
1 parent be7d554 commit 9d14393
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,12 @@ Quick Links

* Our prow jobs are defined in [config.yaml](https://github.com/kubernetes/test-infra/blob/master/prow/config.yaml)
* Each prow job defines a K8s PodSpec indicating a command to run
* Our prow jobs use [run_e2e_workflow.py](https://github.com/py/kubeflow/testing/run_e2e_workflow.py)
* Our prow jobs use [run_e2e_workflow.py](https://github.com/kubeflow/testing/blob/master/py/kubeflow/testing/run_e2e_workflow.py)
to trigger an Argo workflow that checks out our code and runs our tests.
* Our tests are structured as Argo workflows so that we can easily perform steps in parallel.
* The Argo workflow is defined in the repository being tested
* We always use the worfklow at the commit being tested
* [checkout.sh](https://github.com/kubeflow/testing/images/checkout.sh) is used to checkout the code being tested
* [checkout.sh](https://github.com/kubeflow/testing/blob/master/images/checkout.sh) is used to checkout the code being tested
* This also checks out [kubeflow/testing]((https://github.com/kubeflow/testing/) so that all repositories can
rely on it for shared tools.

Expand Down Expand Up @@ -345,4 +345,5 @@ kubectl create clusterrolebinding default-admin --clusterrole=cluster-admin --us
Webhooks for prow should already be configured according to these [instructions](https://github.com/kubernetes/test-infra/blob/master/prow/getting_started.md#add-the-webhook-to-github) for the org so you shouldn't
need to set hooks per repository.
* Use https://prow.k8s.io/hook as the target
* Get HMAC token from k8s test team
* Get HMAC token from k8s test team

0 comments on commit 9d14393

Please sign in to comment.