Fix build error if INITRAMFS_IMAGE undefined #637
Conversation
|
Also could you please expand CI configuration so that such cases can be caught (please submit a PR with CI changes separately so that we can merge it first and then test this PR against the merged tree). |
Sure, I'll update CI scripts in a separate PR and get back. |
Reword error message looking for a valid kernel image as SKIP_RECIPE[linux-qcom-uki] also mentioning the same. Signed-off-by: Viswanath Kraleti <quic_vkraleti@quicinc.com>
quic-vkraleti
force-pushed
the
uki-changes
branch
from
8881f12
to
41f417e
Compare
|
I don't see CI failing after the CI change in #639 . Was it enough to demonstrate the issue being fixed by this PR? |
To reproduce need to set INITRAMFS_IMAGE = "". Is there any configuration in CI that tests kernel without initrd? |
I asked you to add necessary CI configuration. |
#644 updated build template to build with & without initramfs. |
|
@quic-vkraleti any chance of getting this done? I'd like to merge the fix and then backport necessary changes to the |
Below error seen when INITRAMFS_IMAGE is undefined. Fix it by defining
INITRAMFS_IMAGE with a weak assignment.
ERROR: Error for linux-qcom-uki.bb:do_configure[depends], dependency
'${@ '${INITRAMFS_IMAGE}:do_image_complete' if d.getVar('INITRAMFS_IMAGE') else ''}' does not contain exactly one ':' character.
Task 'depends' should be specified in the form 'packagename:task'
Signed-off-by: Viswanath Kraleti <quic_vkraleti@quicinc.com>
quic-vkraleti
force-pushed
the
uki-changes
branch
from
41f417e
to
2de73af
Compare
Sorry for the delay. Updated as requested. Please check. |
|
Thank you! LGTM! |
Fixed below error in linux-qcom-uki.bb when INITRAMFS_IMAGE is undefined.
ERROR: Error for linux-qcom-uki.bb:do_configure[depends], dependency '${@ '${INITRAMFS_IMAGE}:do_image_complete' if d.getVar('INITRAMFS_IMAGE') else ''}' does not contain exactly one ':' character. Task 'depends' should be specified in the form 'packagename:task'