Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the empty value returned for Humidity, CO2, and HCHO; increased the timeout to 30 minutes. #129

Merged
merged 2 commits into from
Jan 29, 2023

Conversation

grinco
Copy link
Contributor

@grinco grinco commented Jan 29, 2023

Breaking change

Proposed change

Skip initialization of sensors with an empty response;
Increase the timeout to 30 minutes (items were unavailable quite often with a 30 second timeout).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an this integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • The code has been formatted using Black (black --fast custom_components)

If user exposed functionality or configuration variables are added/changed:

  • Documentation added/updated to README.md

Limych#126

Signed-off-by: Vadim Grinco <vadim@grinco.eu>
Signed-off-by: Vadim Grinco <vadim@grinco.eu>
@Limych Limych merged commit c8da1a0 into Limych:dev Jan 29, 2023
@Limych
Copy link
Owner

Limych commented Jan 29, 2023

Thanks ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stopped working after upgrade to 2022.12
2 participants