Skip to content

Commit

Permalink
Fix PR template
Browse files Browse the repository at this point in the history
  • Loading branch information
Limych committed May 15, 2020
1 parent f7a3bb2 commit f881581
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 7 deletions.
8 changes: 5 additions & 3 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
<!--
You are amazing! Thanks for contributing to our project!
Please, DO NOT DELETE ANY TEXT from this template! (unless instructed).
Please note, ANY pull requests to MASTER BRANCH will be CLOSED.
Use develop branch instead.
-->
## Breaking change
<!--
Expand Down Expand Up @@ -31,8 +34,7 @@

- [ ] Dependency upgrade
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New integration (thank you!)
- [ ] New feature (which adds functionality to an existing integration)
- [ ] New feature (which adds functionality to an this integration)
- [ ] Breaking change (fix/feature causing existing functionality to break)
- [ ] Code quality improvements to existing code or addition of tests

Expand Down Expand Up @@ -68,7 +70,7 @@

- [ ] The code change is tested and works locally.
- [ ] There is no commented out code in this PR.
- [ ] The code has been formatted using Black (`black --fast homeassistant tests`)
- [ ] The code has been formatted using Black (`black --fast custom_components`)

If user exposed functionality or configuration variables are added/changed:

Expand Down
2 changes: 1 addition & 1 deletion custom_components/jq300/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ async def async_setup(hass, config):
# Print startup message
_LOGGER.info("Version %s", VERSION)
_LOGGER.info(
"If you have ANY issues with this," " please report them here: %s", ISSUE_URL
"If you have ANY issues with this, please report them here: %s", ISSUE_URL
)

hass.data.setdefault(DOMAIN, {})
Expand Down
2 changes: 1 addition & 1 deletion script/bootstrap
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
# Stop on errors
set -e

ROOT="$( cd "$( dirname "${BASH_SOURCE[0]}" )/.." >/dev/null 2>&1 && pwd )"
ROOT="$( cd "$( dirname "$(readlink -f "$0")" )/.." >/dev/null 2>&1 && pwd )"

cd "${ROOT}"

Expand Down
3 changes: 2 additions & 1 deletion script/setup
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,13 @@
# Stop on errors
set -e

ROOT="$( cd "$( dirname "${BASH_SOURCE[0]}" )/.." >/dev/null 2>&1 && pwd )"
ROOT="$( cd "$( dirname "$(readlink -f "$0")" )/.." >/dev/null 2>&1 && pwd )"

cd "${ROOT}"
script/bootstrap

pre-commit install
pip3 install -r requirements-dev.txt

CONFIG=/run/user/$(id -u)/gvfs/smb-share:server=hassio,share=config/
if [ -d "$CONFIG" ] && [ ! -e dev-config ]; then
Expand Down
2 changes: 1 addition & 1 deletion script/update
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
# Stop on errors
set -e

ROOT="$( cd "$( dirname "${BASH_SOURCE[0]}" )/.." >/dev/null 2>&1 && pwd )"
ROOT="$( cd "$( dirname "$(readlink -f "$0")" )/.." >/dev/null 2>&1 && pwd )"

cd "${ROOT}"
git pull
Expand Down

0 comments on commit f881581

Please sign in to comment.