finished test_docker_util w/my #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test looks good, I will check the inspect_container. I think it should still be - not _. The prefix is csle_... but the container name is e.g., "csle_client_1_1-level14-15". So splitting on "-" you get three parts: name, the level, and the id. |
|
i think you are right, I changed it |
|
Good, change the line in docker_util_py also |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed a small bug in docker_util, line 120.
CSLE_PREFIX is "csle_" not "csle-"
Also in the test file, line 190, mock_inspect_container should be called but not, weird.