Use stream_get_contents() instead of multiple fread() (#45)

* Use stream_get_contents() * Check for failures
Limenius · Oct 1, 2020 · 2ced65b · 2ced65b
1 parent 43d4a2b
commit 2ced65b
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/src/Limenius/ReactRenderer/Renderer/ExternalServerReactRenderer.php b/src/Limenius/ReactRenderer/Renderer/ExternalServerReactRenderer.php
@@ -64,11 +64,10 @@ public function render($componentName, $propsString, $uuid, $registeredStores =
         }
         stream_socket_sendto($sock, $this->wrap($componentName, $propsString, $uuid, $registeredStores, $trace)."\0");
 
-        $contents = '';
-
-        while (!feof($sock)) {
-            $contents .= fread($sock, 8192);
+        if (false === $contents = stream_get_contents($sock)) {
+            throw new \RuntimeException('Failed to read content from external renderer.');
         }
+
         fclose($sock);
 
         $result = json_decode($contents, true);