refactor: use strings.EqualFold

[zhuhaicity]

Summary

strings.EqualFold has no memory overhead and has better performance than strings.ToLower.

This is a performance test:

package bench

import (
	"strings"
	"testing"
)

func BenchmarkToLower(b *testing.B) {

	str1 := "Windows"
	str2 := "windows"

	for i := 0; i < b.N; i++ {
		if strings.ToLower(str1) == strings.ToLower(str2) {
		}
	}
}

func BenchmarkEqualFold(b *testing.B) {

	str1 := "Windows"
	str2 := "windows"

	for i := 0; i < b.N; i++ {
		if strings.EqualFold(str1, str2) {
		}
	}
}

The result:

goos: darwin
goarch: arm64
BenchmarkToLower-8      31404808                36.99 ns/op            8 B/op          1 allocs/op
BenchmarkEqualFold-8    194780793                5.989 ns/op           0 B/op          0 allocs/op
PASS

Task/Issue reference

Closes: add_link_here

Test plan

Please describe how reviewers can test the changes in this pull request. If the test plan is challenging to explain in text alone, a short video demonstration may be included.

Details (optional)

Add any additional details that will help to review this pull request.

Related issues or PRs (optional)

Add any related issues or PRs.

[cla-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @zhuhaicity on file. In order for us to review and merge your code, please open a new pull request and sign the Contributor License Agreement following the instructions in our contributing guide. Once the pull request is merged, ping a maintainer who will summon me again.

[cla-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @zhuhaicity on file. In order for us to review and merge your code, please open a new pull request and sign the Contributor License Agreement following the instructions in our contributing guide. Once the pull request is merged, ping a maintainer who will summon me again.

[bgins]

Excellent, thanks @zhuhaicity! Much faster. 😄

We are holding off on merging PRs until after tomorrow's release, but I'll this merged right after.

Question for you. Would you like to receive Lilybit rewards for your contribution? We have an open source program to reward contributors when we launch to mainnet.

[zhuhaicity]

Excellent, thanks @zhuhaicity! Much faster. 😄

We are holding off on merging PRs until after tomorrow's release, but I'll this merged right after.

Question for you. Would you like to receive Lilybit rewards for your contribution? We have an open source program to reward contributors when we launch to mainnet.

Ha ha, thank you so much. It’s my honor.

If there’s a reward, that would be great! Do I need to provide anything?

[bgins]

If there’s a reward, that would be great! Do I need to provide anything?

In general, we are tracking contributions that have been taken up by community through issues. I've opened an issue to track your contribution here: #485

It would be helpful to know your Discord username so we can contact you when we distribute rewards. Are you in the Lilypad Discord? If not, would you be up for joining? https://discord.gg/DHMgfVSD

[bgins]

@zhuhaicity actually, there is one thing you could do. Could you comment on the issue I made for this contribution? #485

A simple comment like "I have implemented this" would be fine. It's just a formality so I can assign you to the issue in GitHub for our tracking.

[bgins]

We've delayed our release, so might be a couple more days before we get this merged.

[zhuhaicity]

If there’s a reward, that would be great! Do I need to provide anything?

In general, we are tracking contributions that have been taken up by community through issues. I've opened an issue to track your contribution here: #485

It would be helpful to know your Discord username so we can contact you when we distribute rewards. Are you in the Lilypad Discord? If not, would you be up for joining? https://discord.gg/DHMgfVSD

Thank you very much!

I have joined the discord group, my id is bitcatty.

[zhuhaicity]

We've delayed our release, so might be a couple more days before we get this merged.

Already commented. No rush, thank you very much!

[bgins]

We've delayed our release, so might be a couple more days before we get this merged.

Already commented. No rush, thank you very much!

Alright great! Assigned you to the issue, so we should be good to go. 😃