refactor: Refactor solver store helpers #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We will also want this helper function in the database implementation.
bgins
force-pushed
the
bgins/refactor-solver-store-helpers
branch
from
7742ae6 to
888df46
Compare
|
@cla-bot check |
walkah
pushed a commit
that referenced
this pull request
Dec 10, 2024
* refactor: Rename types.go to store.go * refactor: Move GetMatchID to parent for reuse We will also want this helper function in the database implementation. * refactor: Move log writer creation to helper function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request makes the following changes:
pkg/solver/store/types.gotopkg/solver/store/store.goThe changes in this pull request are preparatory work in support of #445.
Task/Issue reference
Implements: #445
Test plan
Start the stack. Run a job. Run the integration tests.
To test the log writers, tail
/var/tmp/lilypad_deals.jsonland watch for a new deal entry when running a job.Related issues or PRs (optional)
Epic: https://github.com/Lilypad-Tech/internal/issues/340