Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing #16

Merged
merged 95 commits into from
Dec 13, 2021
Merged

Testing #16

merged 95 commits into from
Dec 13, 2021

Conversation

LilithHafner
Copy link
Owner

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2021

Codecov Report

Merging #16 (74dad3f) into main (fbd5324) will increase coverage by 3.49%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
+ Coverage   83.68%   87.17%   +3.49%     
==========================================
  Files           1        1              
  Lines         190      195       +5     
==========================================
+ Hits          159      170      +11     
+ Misses         31       25       -6     
Impacted Files Coverage Δ
src/UpdateJulia.jl 87.17% <100.00%> (+3.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbd5324...74dad3f. Read the comment docs.

@LilithHafner
Copy link
Owner Author

This is good work, but not quite ready to merge into main. We need to code review and ensure we're not accidentally loosing any of main's testing. Specifically, we need to be reasonably sure that bugs that we explicitly test for in main will also be effectively caught here (i.e. guaranteed or very high probability).

The API improvements discovered and implemented here have just been added to main in c06207a and 0ed9578 for the 0.3.0 release.

@LilithHafner LilithHafner changed the base branch from main to migrate-packages December 10, 2021 00:14
@LilithHafner LilithHafner changed the base branch from migrate-packages to main December 10, 2021 02:46
@LilithHafner
Copy link
Owner Author

That was a rebase

…ber major.minor (and no overwrite). No longer automatically attempts teh failed migration from 1.8.0-DEV to 1.0.1
@LilithHafner
Copy link
Owner Author

Looks good to me!

@LilithHafner LilithHafner merged commit a4463ee into main Dec 13, 2021
LilithHafner added a commit that referenced this pull request Dec 13, 2021
- remove known issues section because the package migration part is fixed & the windows disclaimer is long, not particularly insightful or helpful, and not an actual issue as far as I'm aware of.

- update to reflect docstring change from testing PR #16

- add example usage to install release candidates and nightly
@LilithHafner LilithHafner deleted the testing branch December 13, 2021 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants