Format the lib (no major code changes) and migrate to Poetry #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lib is plauged with literally 10+ uses of unsafe execs. I think I need to refer to Jishaku or Sinbad or Umbra for how to safely do execs
|
Also I'm not kidding when I had to disable Bandit. I will be very interested to see what Ruff has to offer for its results
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I formatted the lib to use Black (there are no code changes) so the codebase would be more consistent with others pulling in. Also migrated to using Poetry, and the biggest thing is I pinned dpy as a dev lib instead of a prod lib. A namespace check within the base
__init__.pywould be needed (see better-ipc's implementation of this) to ensure that we have dpy imported for any user libs.Other than that, I finally have added a proper
.gitignorefile so random cache/build stuff would not be tracked, and your PyCharm idea configs are fine. Also added the testing libs that would be needed, and any new dev libs that would be useful or used.From Noelle