Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Xcodeproj to 1.27.0 #129

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

andrewash
Copy link
Contributor

@andrewash andrewash commented Nov 27, 2024

The Fix

Bump Xcodeproj version requirements to allow version 1.27.0

The latest version of cocoapods, 1.16.2 now requires at minimum 1.27.0 of xcodeproj
See these release notes

This PR bumps Xcodeproj to restore compatibility between the latest versions of Kintsugi and Cocoapods.

I've verified that running bundle install within my project whose Gemfile depends on kintsugi now works. However I haven't tested the functionality of kintsugi for compatibility with xcodeproj 1.27.0 as I'm not sure what to test for.

I hope this is helpful, in any case.

The Bug

Before this PR, running bundle install within my project root results in this error

Fetching https://github.com/pbsupplyco/Kintsugi.git
Fetching gem metadata from https://rubygems.org/........
Resolving dependencies...
Could not find compatible versions

Because every version of kintsugi depends on xcodeproj >= 1.19.0, <= 1.25.0
  and cocoapods >= 1.16.2 depends on xcodeproj >= 1.27.0, < 2.0,
  every version of kintsugi is incompatible with cocoapods >= 1.16.2.
So, because Gemfile depends on cocoapods = 1.16.2
  and Gemfile depends on kintsugi >= 0,
  version solving has failed.

FYI before this fix, my Gemfile had

source 'https://rubygems.org'

ruby '~> 3.2.1'

gem 'activesupport', '= 7.0.8'
gem 'cocoapods', '= 1.16.2'
gem 'fastlane', '~> 2.225.0'
gem 'kintsugi', require: false

Once I updated kintsugi to run off the feature branch I'm merging in, it worked fine.

…1.16.2

Signed-off-by: Andrew Ash <aash@photoboothsupplyco.com>
@andrewash andrewash marked this pull request as ready for review November 27, 2024 20:36
@barakwei
Copy link
Member

Thanks @andrewash!

@barakwei barakwei merged commit 3d8fc38 into Lightricks:main Nov 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants