-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed CPC module arg name #680
Conversation
Codecov Report
@@ Coverage Diff @@
## master #680 +/- ##
=======================================
Coverage 24.83% 24.83%
=======================================
Files 119 119
Lines 7321 7321
=======================================
Hits 1818 1818
Misses 5503 5503
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Oops sorry I didnt mean to request review again from @Borda 😬 |
self.hparams.encoder was renamed to self.hparams.encoder_name in a8e3fb5 Lightning-Universe#264 Rename overlooked occurrence as in 2163626 Lightning-Universe#680
What does this PR do?
Fixes #679
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Yes :)
Make sure you had fun coding 🙃