-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tests for trainer.fit returning None in PL 1.3.0 #641
Conversation
Codecov Report
@@ Coverage Diff @@
## master #641 +/- ##
==========================================
+ Coverage 71.46% 71.83% +0.36%
==========================================
Files 118 118
Lines 7129 7129
==========================================
+ Hits 5095 5121 +26
+ Misses 2034 2008 -26
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This PR is now ready for your review @Borda |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thank you!
What does this PR do?
Found in #633.
This PR updates the tests comparing with return value of
trainer.fit(...)
sincetrainer.fit
always returnsNone
from PL 1.3. Lightning-AI/pytorch-lightning#7237Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃