Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests for trainer.fit returning None in PL 1.3.0 #641

Merged
merged 3 commits into from
May 11, 2021

Conversation

akihironitta
Copy link
Contributor

@akihironitta akihironitta commented May 11, 2021

What does this PR do?

Found in #633.

This PR updates the tests comparing with return value of trainer.fit(...) since trainer.fit always returns None from PL 1.3. Lightning-AI/pytorch-lightning#7237

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@akihironitta akihironitta added fix fixing issues... ci/cd Continues Integration and delivery labels May 11, 2021
@codecov
Copy link

codecov bot commented May 11, 2021

Codecov Report

Merging #641 (172a45c) into master (f0950d2) will increase coverage by 0.36%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #641      +/-   ##
==========================================
+ Coverage   71.46%   71.83%   +0.36%     
==========================================
  Files         118      118              
  Lines        7129     7129              
==========================================
+ Hits         5095     5121      +26     
+ Misses       2034     2008      -26     
Flag Coverage Δ
cpu 71.83% <ø> (+0.36%) ⬆️
pytest 71.83% <ø> (+0.36%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pl_bolts/datasets/cifar10_dataset.py 72.04% <0.00%> (-25.81%) ⬇️
pl_bolts/datasets/base_dataset.py 81.81% <0.00%> (-13.64%) ⬇️
pl_bolts/models/rl/dqn_model.py 80.45% <0.00%> (+0.57%) ⬆️
pl_bolts/models/rl/reinforce_model.py 89.47% <0.00%> (+0.75%) ⬆️
pl_bolts/datamodules/experience_source.py 95.90% <0.00%> (+0.81%) ⬆️
...l_bolts/models/rl/vanilla_policy_gradient_model.py 95.90% <0.00%> (+0.81%) ⬆️
pl_bolts/models/rl/per_dqn_model.py 86.88% <0.00%> (+1.63%) ⬆️
pl_bolts/models/rl/noisy_dqn_model.py 82.97% <0.00%> (+2.12%) ⬆️
...l_bolts/models/self_supervised/byol/byol_module.py 51.57% <0.00%> (+28.42%) ⬆️
pl_bolts/callbacks/byol_updates.py 100.00% <0.00%> (+31.81%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0950d2...172a45c. Read the comment docs.

@akihironitta akihironitta changed the title Update tests for trainer.fit returning None [WIP] Update tests for trainer.fit returning None May 11, 2021
@akihironitta akihironitta changed the title [WIP] Update tests for trainer.fit returning None Update tests for trainer.fit returning None May 11, 2021
@akihironitta
Copy link
Contributor Author

This PR is now ready for your review @Borda

@akihironitta akihironitta changed the title Update tests for trainer.fit returning None Update tests for trainer.fit returning None in PL 1.3.0 May 11, 2021
@akihironitta akihironitta added the Priority High priority task label May 11, 2021
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you!

@Borda Borda merged commit b236f21 into master May 11, 2021
@Borda Borda deleted the tests/fit-returns-none branch May 11, 2021 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd Continues Integration and delivery fix fixing issues... Priority High priority task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants