-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docstring for GIoU metric #474
Conversation
Codecov Report
@@ Coverage Diff @@
## master #474 +/- ##
==========================================
+ Coverage 80.52% 80.75% +0.22%
==========================================
Files 103 103
Lines 5710 5710
==========================================
+ Hits 4598 4611 +13
+ Misses 1112 1099 -13
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@briankosw Thank you! Can we have the same update for pytorch-lightning-bolts/pl_bolts/losses/object_detection.py
?
Co-authored-by: Akihiro Nitta <nitta@akihironitta.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@briankosw Looks great to me. Thank you for your contribution as always!
What does this PR do?
Updates the docstring for GIoU metric #469 (comment). @akihironitta
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃