Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cache in DNSMOS metric #2974

Merged
merged 8 commits into from
Feb 27, 2025
Merged

Fix cache in DNSMOS metric #2974

merged 8 commits into from
Feb 27, 2025

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Feb 25, 2025

What does this PR do?

Fixes #2924

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2974.org.readthedocs.build/en/2974/

@SkafteNicki SkafteNicki added bug / fix Something isn't working enhancement New feature or request labels Feb 25, 2025
@SkafteNicki SkafteNicki added this to the v1.5.x milestone Feb 25, 2025
@SkafteNicki SkafteNicki self-assigned this Feb 25, 2025
@SkafteNicki SkafteNicki marked this pull request as ready for review February 26, 2025 06:32
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 36%. Comparing base (3c01c57) to head (08fb977).
Report is 3 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (3c01c57) and HEAD (08fb977). Click for more details.

HEAD has 52 uploads less than BASE
Flag BASE (3c01c57) HEAD (08fb977)
torch2.0.1+cpu 6 3
python3.10 18 9
Windows 4 2
cpu 27 14
torch2.6.0+cpu 2 1
python3.12 5 3
macOS 5 3
torch2.0.1 4 2
Linux 18 9
torch2.3.1+cpu 2 1
python3.9 2 1
torch2.4.1+cpu 4 2
python3.11 2 1
torch2.2.2+cpu 2 1
torch2.5.0+cpu 4 2
torch2.1.2+cpu 2 1
Additional details and impacted files
@@           Coverage Diff            @@
##           master   #2974     +/-   ##
========================================
- Coverage      70%     36%    -34%     
========================================
  Files         348     348             
  Lines       19469   19475      +6     
========================================
- Hits        13607    6977   -6630     
- Misses       5862   12498   +6636     

@mergify mergify bot added the ready label Feb 26, 2025
@Borda Borda enabled auto-merge (squash) February 26, 2025 12:35
@Borda Borda disabled auto-merge February 27, 2025 09:57
@Borda Borda merged commit 15dd983 into master Feb 27, 2025
60 checks passed
@Borda Borda deleted the bugfix/dnsmos_cache branch February 27, 2025 10:26
Borda pushed a commit that referenced this pull request Feb 28, 2025
* new arg + test
* add arg description
* fix tests
* Changelog

(cherry picked from commit 15dd983)
Borda pushed a commit that referenced this pull request Mar 3, 2025
* new arg + test
* add arg description
* fix tests
* Changelog

(cherry picked from commit 15dd983)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working enhancement New feature or request ready topic: Audio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memory leak DNSMOS functional interface
2 participants