Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: correct skipif sense #2931

Merged

Conversation

martin-kokos
Copy link
Contributor

@martin-kokos martin-kokos commented Feb 1, 2025

What does this PR do?

Tests are skipped even if though the libs they use are installed. Check appears to be inverted by accident.
Fixes inverted skipif check.

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2931.org.readthedocs.build/en/2931/

Copy link

codecov bot commented Feb 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36%. Comparing base (767c678) to head (dcfe914).
Report is 8 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (767c678) and HEAD (dcfe914). Click for more details.

HEAD has 212 uploads less than BASE
Flag BASE (767c678) HEAD (dcfe914)
macOS 16 4
python3.11 16 4
cpu 68 17
torch2.6.0 4 1
torch2.6.0+cpu 8 2
Windows 12 3
python3.12 12 3
torch2.5.0 4 1
python3.10 36 9
torch2.0.1 8 2
torch2.0.1+cpu 12 3
torch2.5.0+cpu 12 3
Linux 40 10
torch2.4.1+cpu 8 2
torch2.2.2+cpu 4 1
python3.9 4 1
torch2.3.1+cpu 4 1
gpu 4 0
unittest 4 0
torch2.1.2+cpu 4 1
Additional details and impacted files
@@           Coverage Diff            @@
##           master   #2931     +/-   ##
========================================
- Coverage      69%     36%    -33%     
========================================
  Files         346     332     -14     
  Lines       19172   18996    -176     
========================================
- Hits        13236    6773   -6463     
- Misses       5936   12223   +6287     

@Borda Borda merged commit 6438cd5 into Lightning-AI:master Feb 3, 2025
57 of 65 checks passed
@mergify mergify bot added the ready label Feb 3, 2025
Borda pushed a commit that referenced this pull request Feb 28, 2025
Co-authored-by: Martin Mokry <martin-kokos@users.noreply.github.com>
(cherry picked from commit 6438cd5)
Borda pushed a commit that referenced this pull request Mar 3, 2025
Co-authored-by: Martin Mokry <martin-kokos@users.noreply.github.com>
(cherry picked from commit 6438cd5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants