Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: cleaning classif. #2815

Merged
merged 4 commits into from
Oct 31, 2024
Merged

tests: cleaning classif. #2815

merged 4 commits into from
Oct 31, 2024

Conversation

Borda
Copy link
Member

@Borda Borda commented Oct 31, 2024

What does this PR do?

clarify using arguments and adding tests

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2815.org.readthedocs.build/en/2815/

@Borda Borda merged commit dfc9e33 into master Oct 31, 2024
48 of 52 checks passed
@Borda Borda deleted the test/cleaning branch October 31, 2024 21:01
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69%. Comparing base (d52cb48) to head (3d7f057).
Report is 1 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #2815   +/-   ##
======================================
  Coverage      69%     69%           
======================================
  Files         344     344           
  Lines       18828   18828           
======================================
  Hits        12975   12975           
  Misses       5853    5853           

Borda added a commit that referenced this pull request Nov 7, 2024
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit dfc9e33)
Borda added a commit that referenced this pull request Nov 7, 2024
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit dfc9e33)
Borda added a commit that referenced this pull request Nov 7, 2024
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit dfc9e33)
Borda added a commit that referenced this pull request Nov 7, 2024
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit dfc9e33)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant