-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
experimenting with error improvements #2431
Changes from all commits
28978c8
925c016
836a985
e9bdbd9
0530f4c
cd64d62
f716fcc
b28d53d
791cf0d
5fccf1c
c887edd
29d55e0
af0ebe9
5eca426
53c47ec
4b57d86
128d3a7
a2b2744
87b9cf9
41f174b
ef06770
1b30064
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,6 +14,9 @@ | |
_PACKAGE_ROOT = os.path.dirname(__file__) | ||
_PROJECT_ROOT = os.path.dirname(_PACKAGE_ROOT) | ||
|
||
if package_available("pretty_errors"): | ||
import pretty_errors # noqa: F401 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It seems like importing torchmetrics now has the effect of changing error messages for all other code. This seems undesirable. Couldn't this be left up to the user? Or the dependency made optional? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also seems unmaintained: onelivesleft/PrettyErrors#57 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. sure, check #2527 |
||
|
||
if package_available("PIL"): | ||
import PIL | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any chance we can relax this version constraint in the future?