Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fixture for use_deterministic_algorithms #2351

Merged
merged 4 commits into from
Feb 7, 2024

Conversation

Borda
Copy link
Member

@Borda Borda commented Feb 5, 2024

What does this PR do?

Better/robust solution for hotfix in #2350 (comment)

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2351.org.readthedocs.build/en/2351/

@Borda Borda added the test / CI testing or CI label Feb 5, 2024
@Borda Borda force-pushed the tests/use_deterministic_algorithms branch from ac19f78 to 4c620a5 Compare February 5, 2024 18:47
Copy link

codecov bot commented Feb 5, 2024

Codecov Report

Merging #2351 (b066148) into master (0aafdc9) will not change coverage.
Report is 5 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #2351   +/-   ##
======================================
  Coverage      69%     69%           
======================================
  Files         303     303           
  Lines       17058   17058           
======================================
  Hits        11760   11760           
  Misses       5298    5298           

@Borda Borda enabled auto-merge (squash) February 5, 2024 21:27
@Borda Borda requested a review from a team February 5, 2024 21:27
@mergify mergify bot added the ready label Feb 6, 2024
@Borda Borda disabled auto-merge February 7, 2024 23:34
@Borda Borda merged commit dc115fe into master Feb 7, 2024
39 of 48 checks passed
@Borda Borda deleted the tests/use_deterministic_algorithms branch February 7, 2024 23:36
Borda added a commit that referenced this pull request Feb 12, 2024
Borda added a commit that referenced this pull request Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready test / CI testing or CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants