-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): update pytorch-lightning requirement from <2.0.0,>=1.9.0 to >=1.9.0,<2.1 in /requirements #2175
build(deps): update pytorch-lightning requirement from <2.0.0,>=1.9.0 to >=1.9.0,<2.1 in /requirements #2175
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2175 +/- ##
======================================
Coverage 69% 69%
======================================
Files 313 313
Lines 17617 17617
======================================
Hits 12162 12162
Misses 5455 5455 |
pending on #2129 |
@dependabot rebase |
55f1c45
to
f96e4c5
Compare
f96e4c5
to
a7e1731
Compare
PR on lightning side that seems to break tests: Lightning-AI/pytorch-lightning#18567 |
@Borda I fixed a few issues, but I am still unable to reproduce the difference in values for the integration testing. |
…ing-gte-1.6.0-and-lt-2.2.0
it is strange as it passes for me locally with single GPU |
it is strange, seems to hang with |
…ing-gte-1.6.0-and-lt-2.2.0
…ing-gte-1.6.0-and-lt-2.2.0
…ing-gte-1.6.0-and-lt-2.2.0
…ing-gte-1.6.0-and-lt-2.2.0
…ing-gte-1.6.0-and-lt-2.2.0
…ing-gte-1.6.0-and-lt-2.2.0
84dda8b
to
a4676c7
Compare
7307925
to
c85fe11
Compare
so the problem is the multi-GPU case which was likely the switched for defaults between 1.x and 2.x |
…ing-gte-1.6.0-and-lt-2.2.0
… to >=1.9.0,<2.1 in /requirements (Lightning-AI#2175) * build(deps): update pytorch-lightning requirement in /requirements Updates the requirements on [pytorch-lightning](https://github.com/Lightning-AI/lightning) to permit the latest version. - [Release notes](https://github.com/Lightning-AI/lightning/releases) - [Commits](Lightning-AI/pytorch-lightning@1.6.0...2.1.0) --- updated-dependencies: - dependency-name: pytorch-lightning dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * fix for v2.0 or higher * <2.1.0 * fix seed * Apply suggestions from code review CI would run only with single GPU --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: SkafteNicki <skaftenicki@gmail.com> Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Jirka <jirka.borovec@seznam.cz>
… to >=1.9.0,<2.1 in /requirements (#2175) * build(deps): update pytorch-lightning requirement in /requirements Updates the requirements on [pytorch-lightning](https://github.com/Lightning-AI/lightning) to permit the latest version. - [Release notes](https://github.com/Lightning-AI/lightning/releases) - [Commits](Lightning-AI/pytorch-lightning@1.6.0...2.1.0) --- updated-dependencies: - dependency-name: pytorch-lightning dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * fix for v2.0 or higher * <2.1.0 * fix seed * Apply suggestions from code review CI would run only with single GPU --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: SkafteNicki <skaftenicki@gmail.com> Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Jirka <jirka.borovec@seznam.cz> (cherry picked from commit 25bf7a6)
Updates the requirements on pytorch-lightning to permit the latest version.
Release notes
Sourced from pytorch-lightning's releases.
... (truncated)
Commits
6f6c07d
Revert removal of empty-parameters check forconfigure_optimizers()
with FS...20ce3ae
docs: setting cron for periodical update tutorials (#18783)9f17324
Update probot-check-group.yml to v5.4 (#18782)c5e3c45
Save ModelCheckpoint'slast.ckpt
as symlink if possible (#18748)7434c47
Raise an exception when callingfit
twice with spawn (#18776)5a83f54
Minor strategy fixes [TPU] (#18774)4df6e13
Update version and changelog (#18767)83abe5e
Bugfix: Pinlightning-cloud
version (#18778)27ad9e9
xfail collective tests (#18779)c39f680
Fix deletion of resumed checkpoints (#18750)You can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)📚 Documentation preview 📚: https://torchmetrics--2175.org.readthedocs.build/en/2175/