-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support save_hyperparameters()
in LightningModule dataclass
#7992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #7992 +/- ##
======================================
- Coverage 92% 91% -0%
======================================
Files 207 207
Lines 13368 13406 +38
======================================
Hits 12238 12238
- Misses 1130 1168 +38 |
…into feature/save_hparams_dataclass
kaushikb11
reviewed
Jun 15, 2021
awaelchli
requested review from
Borda,
carmocca,
justusschock,
SeanNaren,
tchaton and
williamFalcon
as code owners
June 15, 2021 20:52
kaushikb11
reviewed
Jun 15, 2021
kaushikb11
approved these changes
Jun 15, 2021
Co-authored-by: Kaushik B <45285388+kaushikb11@users.noreply.github.com>
Tests are failing with the latest version. Looking into it! |
@kaushikb11 I think Thomas has the fix here in #7976 in the reinforce file, the Iterable typehint. You could try that. |
@awaelchli I remembered seeing it in PT 1.9 release notes. |
carmocca
approved these changes
Jun 15, 2021
justusschock
approved these changes
Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #3494
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃