Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support save_hyperparameters() in LightningModule dataclass #7992

Merged
merged 9 commits into from
Jun 16, 2021

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Jun 15, 2021

What does this PR do?

Fixes #3494

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Jun 15, 2021

Codecov Report

Merging #7992 (a3647c7) into master (78a14a3) will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #7992   +/-   ##
======================================
- Coverage      92%     91%   -0%     
======================================
  Files         207     207           
  Lines       13368   13406   +38     
======================================
  Hits        12238   12238           
- Misses       1130    1168   +38     

@awaelchli awaelchli added the feature Is an improvement or enhancement label Jun 15, 2021
@awaelchli awaelchli added this to the v1.4 milestone Jun 15, 2021
@awaelchli awaelchli marked this pull request as ready for review June 15, 2021 20:52
awaelchli and others added 2 commits June 15, 2021 22:56
Co-authored-by: Kaushik B <45285388+kaushikb11@users.noreply.github.com>
@kaushikb11
Copy link
Contributor

Tests are failing with the latest version. Looking into it!

@awaelchli
Copy link
Contributor Author

@kaushikb11 I think Thomas has the fix here in #7976 in the reinforce file, the Iterable typehint. You could try that.

@kaushikb11
Copy link
Contributor

@awaelchli I remembered seeing it in PT 1.9 release notes.

@kaushikb11 kaushikb11 enabled auto-merge (squash) June 16, 2021 07:58
@kaushikb11 kaushikb11 merged commit b093a9e into master Jun 16, 2021
@kaushikb11 kaushikb11 deleted the feature/save_hparams_dataclass branch June 16, 2021 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add support for save_hyperparameters with Python Data Class
4 participants