Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate TrainerModelHooksMixin #7422

Merged

Conversation

ananthsub
Copy link
Contributor

@ananthsub ananthsub commented May 7, 2021

What does this PR do?

This PR deprecates TrainerModelHooksMixin in favor of existing signature utilities. This is similar in spirit to #7292, #7180 and #6834 to simplify the Trainer and favor utility functions over inheritance/mixins for reusing code.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@pep8speaks
Copy link

pep8speaks commented May 7, 2021

Hello @ananthsub! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-05-07 06:23:15 UTC

@codecov
Copy link

codecov bot commented May 7, 2021

Codecov Report

Merging #7422 (1b4aae2) into master (28103c6) will decrease coverage by 4%.
The diff coverage is 92%.

@@           Coverage Diff           @@
##           master   #7422    +/-   ##
=======================================
- Coverage      92%     88%    -4%     
=======================================
  Files         200     200            
  Lines       12983   12991     +8     
=======================================
- Hits        11937   11368   -569     
- Misses       1046    1623   +577     

@carmocca carmocca added the ready PRs ready to be merged label May 7, 2021
@carmocca carmocca added this to the v1.4 milestone May 7, 2021
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets also add todo notes :]

@ananthsub
Copy link
Contributor Author

lets also add todo notes :]

which other TODO notes are missing?

@awaelchli
Copy link
Contributor

Looks like one global todo for the whole class is sufficient.

@ananthsub ananthsub merged commit fecce50 into Lightning-AI:master May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants