-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate TrainerModelHooksMixin #7422
Deprecate TrainerModelHooksMixin #7422
Conversation
Hello @ananthsub! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-05-07 06:23:15 UTC |
Codecov Report
@@ Coverage Diff @@
## master #7422 +/- ##
=======================================
- Coverage 92% 88% -4%
=======================================
Files 200 200
Lines 12983 12991 +8
=======================================
- Hits 11937 11368 -569
- Misses 1046 1623 +577 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets also add todo notes :]
which other TODO notes are missing? |
Looks like one global todo for the whole class is sufficient. |
What does this PR do?
This PR deprecates
TrainerModelHooksMixin
in favor of existing signature utilities. This is similar in spirit to #7292, #7180 and #6834 to simplify the Trainer and favor utility functions over inheritance/mixins for reusing code.Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃