Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added optimizer_idx to backward call #733

Merged
merged 1 commit into from
Jan 24, 2020
Merged

Added optimizer_idx to backward call #733

merged 1 commit into from
Jan 24, 2020

Conversation

AntixK
Copy link
Contributor

@AntixK AntixK commented Jan 23, 2020

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
  • Did you read the contributor guideline?
  • Did you make sure to update the docs?
    But the docs should update automatically based on the docstring that I have updated.

What does this PR do?

Fixes #732

@AntixK AntixK requested a review from williamFalcon January 23, 2020 04:39
Borda
Borda approved these changes Jan 23, 2020
View reviewed changes
Copy link
Member

@Borda Borda left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, could you pls just update the docstring for backward to contain the types...

@williamFalcon williamFalcon merged commit 946aef6 into Lightning-AI:master Jan 24, 2020
CarloLucibello
CarloLucibello reviewed Jan 30, 2020
View reviewed changes
pytorch_lightning/trainer/training_loop.py

# track metrics for callbacks
all_callback_metrics.append(callback_metrics)

# track progress bar metrics
self.add_tqdm_metrics(progress_bar_metrics)
self.add_tqdm_metrics(progress_bar_metrics)
Copy link

@CarloLucibello CarloLucibello Jan 30, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this repeated?

Copy link
Member

@Borda Borda Jan 30, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bug... Thx, fix in #768

@Borda Borda mentioned this pull request Jan 30, 2020
Merged
williamFalcon pushed a commit that referenced this pull request Feb 1, 2020
@Borda
update package info (#768)
5e97e66 
* update info

* fix duplicate #733

* update Appveyor budge #626

* budge to master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarloLucibello CarloLucibello CarloLucibello left review comments

@Borda Borda Borda approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better way to set retain_graph
4 participants
@AntixK @Borda @CarloLucibello @williamFalcon