Weekly Patch Release v.1.2.7 [full merge, no squash] #6850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix_hydra * update changelog Co-authored-by: Your Name <you@example.com>
* Update Bolts link * Update Bolts link * formt Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
* Update logic for checking TPUs availability * fix flake8 * add fix
…htning-AI#5952) Co-authored-by: rohitgr7 <rohitgr1998@gmail.com> Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
…-AI#6828) * fix iterable dataset len check * update predict and validate * add validate to test * add changelog * add predict
* sanitize none params during pruning * amend
Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
* Fix DPP + SyncBN Ensure that model is already on correct GPU before applying SyncBN conversion * Fix order of SyncBN for ddp_spawn
|
Hello @kaushikb11! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-04-06 19:38:02 UTC |
) * Add test for symlink support and initial fix * Respond to comment and add docstring * Update CHANGELOG.md * Simplify * Update pytorch_lightning/utilities/cloud_io.py Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com> * Make `LightningLocalFileSystem` protected Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
There seem to be 3 arguments missing in the `lr_find` call in the tunining.py file.
Closed
kaushikb11
requested review from
awaelchli,
Borda,
carmocca,
edenlightning,
justusschock,
SeanNaren,
SkafteNicki and
tchaton
as code owners
awaelchli
approved these changes
Apr 6, 2021
ananthsub
approved these changes
Apr 6, 2021
Codecov Report
@@ Coverage Diff @@
## release/1.2.x #6850 +/- ##
==============================================
- Coverage 91% 88% -4%
==============================================
Files 190 190
Lines 13050 13008 -42
==============================================
- Hits 11923 11406 -517
- Misses 1127 1602 +475 |
|
@Borda There you go! 🎉 |
Skip advanced profiler for torch > 1.8 Skip pytorch profiler for torch > 1.8 Fix save checkpoint logic for TPUs
Borda
previously approved these changes
Apr 6, 2021
Borda
reviewed
Apr 6, 2021
| @@ -203,12 +203,14 @@ def test_step(self, *args, **kwargs): | |||
| def predict(self, *args, **kwargs): | |||
| return self.lightning_module.predict(*args, **kwargs) | |||
|
|
|||
| def save_checkpoint(self, checkpoint: Dict[str, Any], filepath: str) -> None: | |||
| def save_checkpoint(self, filepath: str, weights_only: bool = False) -> None: | |||
There was a problem hiding this comment.
@tchaton @kaushikb11 where/when we changed this API?
There was a problem hiding this comment.
Changed in this PR: 646cf2f
You can use git blame to find the associated PR.
There was a problem hiding this comment.
yes I know I just say that the API is different / not back compatible
awaelchli
approved these changes
Apr 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR review
related to #6083