[typing] Add typehint for broadcast in training type plugin #6777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ananthsub
requested review from
awaelchli,
justusschock,
SeanNaren and
tchaton
as code owners
ananthsub
changed the title
awaelchli
approved these changes
Apr 1, 2021
akihironitta
reviewed
Apr 2, 2021
pytorch_lightning/plugins/training_type/training_type_plugin.py
Outdated
Show resolved
Hide resolved
kaushikb11
reviewed
Apr 2, 2021
| @@ -480,7 +480,7 @@ def connect_precision_plugin(self, plugin: PrecisionPlugin) -> None: | |||
| ) | |||
| self.setup_precision_plugin(plugin) | |||
|
|
|||
| def save_checkpoint(self, checkpoint: Dict[str, Any], filepath) -> None: | |||
| def save_checkpoint(self, checkpoint: Dict[str, Any], filepath: str) -> None: | |||
There was a problem hiding this comment.
Nit: Could it be Path as well?
There was a problem hiding this comment.
@kaushikb11 Path isn't part of the typehint here: https://github.com/PyTorchLightning/pytorch-lightning/blob/1bd5f36a5bf02ba853c04de77647456c64784399/pytorch_lightning/plugins/training_type/training_type_plugin.py#L240
which is why I didn't include it here
Co-authored-by: Akihiro Nitta <nitta@akihironitta.com>
kaushikb11
approved these changes
Apr 2, 2021
Codecov Report
@@ Coverage Diff @@
## master #6777 +/- ##
=======================================
- Coverage 87% 87% -0%
=======================================
Files 192 192
Lines 12183 12349 +166
=======================================
+ Hits 10599 10685 +86
- Misses 1584 1664 +80 |
SkafteNicki
approved these changes
Apr 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #6731
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃