update outdated docs on console logging configuration #6269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6269 +/- ##
=======================================
- Coverage 93% 91% -2%
=======================================
Files 159 159
Lines 11361 11254 -107
=======================================
- Hits 10607 10231 -376
- Misses 754 1023 +269 |
SkafteNicki
reviewed
Mar 1, 2021
| @@ -265,7 +265,7 @@ to see fewer messages like so: | |||
| .. code-block:: python | |||
|
|
|||
| import logging | |||
| logging.getLogger("lightning").setLevel(logging.ERROR) | |||
| logging.getLogger("pytorch_lightning").setLevel(logging.ERROR) | |||
There was a problem hiding this comment.
should this not be consistent with what we have in __init__?
https://github.com/PyTorchLightning/pytorch-lightning/blob/ed67490d93e3f2bd46ba50cc53207492da0df73d/pytorch_lightning/__init__.py#L41
There was a problem hiding this comment.
I am heavily confused right now
All changes from this PR here #5509
seem to have disappeared
There was a problem hiding this comment.
must be gone in the process when we released v1.2?
There was a problem hiding this comment.
ok, I am sad
Then it's better I restore the old branch and try to resend the PR
Thanks for helping me notice that @SkafteNicki
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #6172
These docs are outdated, the logger is attached to the package name and submodules name.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃