-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve epoch_result_store code quality #4875
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like it. So far I only have one minor question regarding performance.
Probably @tchaton is the best one to review this!
pytorch_lightning/trainer/connectors/logger_connector/epoch_result_store.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome cleanup ! Thx.
Codecov Report
@@ Coverage Diff @@
## master #4875 +/- ##
======================================
Coverage 93% 93%
======================================
Files 129 129
Lines 9432 9359 -73
======================================
- Hits 8739 8677 -62
+ Misses 693 682 -11 |
What does this PR do?
Fixes many code smells I found while debugging #4863
No logic changes.
I suggest reviewing the first commit separately. The other commit is just
black
changes.Before submitting
PR review