Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve epoch_result_store code quality #4875

Merged
merged 12 commits into from
Dec 5, 2020
Merged

Improve epoch_result_store code quality #4875

merged 12 commits into from
Dec 5, 2020

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Nov 27, 2020

What does this PR do?

Fixes many code smells I found while debugging #4863
No logic changes.
I suggest reviewing the first commit separately. The other commit is just black changes.

Before submitting

  • [n/a] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • [n/a] Did you make sure to update the documentation with your changes?
  • [n/a] Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • [n/a] If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified; Bugfixes should be including in bug-fix release milestones (m.f.X) and features should be included in (m.X.b) releases.

Copy link
Member

@justusschock justusschock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like it. So far I only have one minor question regarding performance.

Probably @tchaton is the best one to review this!

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome cleanup ! Thx.

@Borda Borda added the feature Is an improvement or enhancement label Nov 30, 2020
@Borda Borda added this to the 1.1.x milestone Nov 30, 2020
@codecov
Copy link

codecov bot commented Nov 30, 2020

Codecov Report

Merging #4875 (9c52318) into master (22bd742) will increase coverage by 0%.
The diff coverage is 94%.

@@          Coverage Diff           @@
##           master   #4875   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         129     129           
  Lines        9432    9359   -73     
======================================
- Hits         8739    8677   -62     
+ Misses        693     682   -11     

@tchaton tchaton merged commit 7234970 into Lightning-AI:master Dec 5, 2020
@Borda Borda modified the milestones: 1.1.x, 1.1 Dec 6, 2020
@carmocca carmocca deleted the fix-4863 branch December 7, 2020 19:32
@carmocca carmocca self-assigned this Nov 1, 2023
@mergify mergify bot added the ready PRs ready to be merged label Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants