Code

optimizer clean up#4658

Code

Merged

SeanNaren merged 136 commits intomasterLightning-AI/pytorch-lightning:masterfrom bugfix/4572_optimizer_stepLightning-AI/pytorch-lightning:bugfix/4572_optimizer_stepCopy head branch name to clipboardDec 1, 2020

+741-332

Commits

Commits on Nov 13, 2020

• add LightningOptimizer

  tchaton

  committed
  943e5f1

  Copy full SHA for 943e5f1

• typo

  tchaton

  committed
  c778036

  Copy full SHA for c778036

• Merge branch 'master' into bugfix/4572_optimizer_step

  tchaton

  authored
  5d00c20

  Copy full SHA for 5d00c20

• add mock closure

  tchaton

  committed
  e4c5a2e

  Copy full SHA for e4c5a2e

• Merge branch 'bugfix/4572_optimizer_step' of https://github.com/PyTorchLightning/pytorch-lightning into bugfix/4572_optimizer_step

  tchaton

  committed
  9681634

  Copy full SHA for 9681634

• typo

  tchaton

  committed
  397e2b4

  Copy full SHA for 397e2b4

• remove logic in optimizer_step

  tchaton

  committed
  3ac8ed1

  Copy full SHA for 3ac8ed1

• update

  tchaton

  committed
  9cf88bd

  Copy full SHA for 9cf88bd

• update

  tchaton

  committed
  d952917

  Copy full SHA for d952917

• update

  tchaton

  committed
  698034a

  Copy full SHA for 698034a

• Merge branch 'master' into bugfix/4572_optimizer_step

  tchaton

  authored
  bbe743a

  Copy full SHA for bbe743a

• desactivate LightningOptimizer for hovorod

  tchaton

  committed
  50af33d

  Copy full SHA for 50af33d

• Merge branch 'bugfix/4572_optimizer_step' of https://github.com/PyTorchLightning/pytorch-lightning into bugfix/4572_optimizer_step

  tchaton

  committed
  99913b6

  Copy full SHA for 99913b6

• resolve flake

  tchaton

  committed
  ad2a99a

  Copy full SHA for ad2a99a

• typo

  tchaton

  committed
  59dec77

  Copy full SHA for 59dec77

• check optimizer name

  tchaton

  committed
  49f3b2e

  Copy full SHA for 49f3b2e

• change name

  tchaton

  committed
  3034eaa

  Copy full SHA for 3034eaa

Commits on Nov 15, 2020

• Merge branch 'master' into bugfix/4572_optimizer_step

  tchaton

  authored
  98a62c4

  Copy full SHA for 98a62c4

Commits on Nov 16, 2020

• added backward to LightningOptimizer

  tchaton

  committed
  3bf605d

  Copy full SHA for 3bf605d

• remove use_lightning_optimizer

  tchaton

  committed
  9d13ca8

  Copy full SHA for 9d13ca8

• move update

  tchaton

  committed
  11868e6

  Copy full SHA for 11868e6

• Merge branch 'master' into bugfix/4572_optimizer_step

  tchaton

  authored
  083dffd

  Copy full SHA for 083dffd

• simplify init

  tchaton

  committed
  3aaeb81

  Copy full SHA for 3aaeb81

• Merge branch 'bugfix/4572_optimizer_step' of https://github.com/PyTorchLightning/pytorch-lightning into bugfix/4572_optimizer_step

  tchaton

  committed
  81bbfee

  Copy full SHA for 81bbfee

• Merge branch 'master' into bugfix/4572_optimizer_step

  tchaton

  authored
  6dc1d00

  Copy full SHA for 6dc1d00

• resolve comments

  tchaton

  committed
  28b2a8f

  Copy full SHA for 28b2a8f

• Merge branch 'bugfix/4572_optimizer_step' of https://github.com/PyTorchLightning/pytorch-lightning into bugfix/4572_optimizer_step

  tchaton

  committed
  91545da

  Copy full SHA for 91545da

Commits on Nov 18, 2020

• Merge branch 'master' into bugfix/4572_optimizer_step

  tchaton

  authored
  52436e4

  Copy full SHA for 52436e4

• resolve bug

  tchaton

  committed
  1a05a9a

  Copy full SHA for 1a05a9a

• Merge branch 'bugfix/4572_optimizer_step' of https://github.com/PyTorchLightning/pytorch-lightning into bugfix/4572_optimizer_step

  tchaton

  committed
  424849b

  Copy full SHA for 424849b

• Merge branch 'master' into bugfix/4572_optimizer_step

  tchaton

  authored
  2cedc5c

  Copy full SHA for 2cedc5c

• update

  tchaton

  committed
  5f9c6b0

  Copy full SHA for 5f9c6b0

• Merge branch 'bugfix/4572_optimizer_step' of https://github.com/PyTorchLightning/pytorch-lightning into bugfix/4572_optimizer_step

  tchaton

  committed
  c805655

  Copy full SHA for c805655

• update

  tchaton

  committed
  d34b417

  Copy full SHA for d34b417

• resolve bugs

  tchaton

  committed
  e62ada1

  Copy full SHA for e62ada1

• resolve flake8

  tchaton

  committed
  b4ad74f

  Copy full SHA for b4ad74f

• set state

  tchaton

  committed
  c81e179

  Copy full SHA for c81e179

• work manual_optimizer_step

  tchaton

  committed
  8b322c1

  Copy full SHA for 8b322c1

• add doc

  tchaton

  committed
  c593d08

  Copy full SHA for c593d08

• add enable_pl_optimizer

  tchaton

  committed
  027ba6f

  Copy full SHA for 027ba6f

• make optimizer_step

  tchaton

  committed
  0219c63

  Copy full SHA for 0219c63

• add make_optimizer_step

  tchaton

  committed
  162b535

  Copy full SHA for 162b535

• add examples

  tchaton

  committed
  86069ff

  Copy full SHA for 86069ff

• resolve test

  tchaton

  committed
  5dbbccc

  Copy full SHA for 5dbbccc

• add test_optimizer_return_options_enable_pl_optimizer

  tchaton

  committed
  e4f42bd

  Copy full SHA for e4f42bd

• add enable_pl_optimizer=True

  tchaton

  committed
  e59d660

  Copy full SHA for e59d660

• Merge branch 'master' into bugfix/4572_optimizer_step

  tchaton

  authored
  c8aebdd

  Copy full SHA for c8aebdd

Commits on Nov 19, 2020

• Merge branch 'master' into bugfix/4572_optimizer_step

  tchaton

  authored
  82d2032

  Copy full SHA for 82d2032

• Merge branch 'master' into bugfix/4572_optimizer_step

  tchaton

  authored
  c110002

  Copy full SHA for c110002

Commits on Nov 20, 2020

• Merge branch 'master' into bugfix/4572_optimizer_step

  tchaton

  authored
  a37ad78

  Copy full SHA for a37ad78

• Merge branch 'master' into bugfix/4572_optimizer_step

  tchaton

  authored
  a5e8a18

  Copy full SHA for a5e8a18

• Merge branch 'master' into bugfix/4572_optimizer_step

  tchaton

  authored
  d3fcdbb

  Copy full SHA for d3fcdbb

Commits on Nov 23, 2020

• Merge branch 'master' into bugfix/4572_optimizer_step

  tchaton

  authored
  525294b

  Copy full SHA for 525294b

• update

  tchaton

  committed
  5fbba23

  Copy full SHA for 5fbba23

• Merge branch 'bugfix/4572_optimizer_step' of https://github.com/PyTorchLightning/pytorch-lightning into bugfix/4572_optimizer_step

  tchaton

  committed
  0d25494

  Copy full SHA for 0d25494

• update tests

  tchaton

  committed
  4f09984

  Copy full SHA for 4f09984

• resolve bugs

  tchaton

  committed
  d785936

  Copy full SHA for d785936

• update

  tchaton

  committed
  01591cb

  Copy full SHA for 01591cb

• set Trainer to False

  tchaton

  committed
  f9627a8

  Copy full SHA for f9627a8

• Merge branch 'master' into bugfix/4572_optimizer_step

  tchaton

  authored
  f6b0a1f

  Copy full SHA for f6b0a1f

• Merge branch 'master' into bugfix/4572_optimizer_step

  tchaton

  authored
  9013985

  Copy full SHA for 9013985

Commits on Nov 24, 2020

• Merge branch 'master' into bugfix/4572_optimizer_step

  tchaton

  authored
  be23cfb

  Copy full SHA for be23cfb

Commits on Nov 25, 2020

• Merge branch 'master' into bugfix/4572_optimizer_step

  tchaton

  authored
  d7e2080

  Copy full SHA for d7e2080

• update

  tchaton

  committed
  ec09fc6

  Copy full SHA for ec09fc6

• resolve bugs

  tchaton

  committed
  81be876

  Copy full SHA for 81be876

• update

  tchaton

  committed
  04b5f18

  Copy full SHA for 04b5f18

• remove from doc

  tchaton

  committed
  b207dc0

  Copy full SHA for b207dc0

• Merge branch 'master' into bugfix/4572_optimizer_step

  tchaton

  authored
  be2c13f

  Copy full SHA for be2c13f

• resolve bug

  tchaton

  committed
  cdc56e6

  Copy full SHA for cdc56e6

• Merge branch 'bugfix/4572_optimizer_step' of https://github.com/PyTorchLightning/pytorch-lightning into bugfix/4572_optimizer_step

  tchaton

  committed
  7cb0fe1

  Copy full SHA for 7cb0fe1

• typo

  tchaton

  committed
  393ef1a

  Copy full SHA for 393ef1a

Commits on Nov 26, 2020

• update

  tchaton

  committed
  4eb11bf

  Copy full SHA for 4eb11bf

• set to True

  tchaton

  committed
  34f6854

  Copy full SHA for 34f6854

• simplification

  tchaton

  committed
  d24e714

  Copy full SHA for d24e714

• typo

  tchaton

  committed
  e2ea18e

  Copy full SHA for e2ea18e

• resolve horovod

  tchaton

  committed
  c55df45

  Copy full SHA for c55df45

• unwrap horovod

  tchaton

  committed
  728ef64

  Copy full SHA for 728ef64

• remove Optimizer

  tchaton

  committed
  b0c220a

  Copy full SHA for b0c220a

• resolve horovod

  tchaton

  committed
  49d629b

  Copy full SHA for 49d629b

• move logic to amp_backend

  tchaton

  committed
  8bdc9bd

  Copy full SHA for 8bdc9bd

• doesn't seem to be pickable

  tchaton

  committed
  fc5f149

  Copy full SHA for fc5f149

• update

  tchaton

  committed
  1d0bf6c

  Copy full SHA for 1d0bf6c

• add again

  tchaton

  committed
  f66fc8d

  Copy full SHA for f66fc8d

• resolve some bugs

  tchaton

  committed
  0a03907

  Copy full SHA for 0a03907

• cleanup

  tchaton

  committed
  f27c046

  Copy full SHA for f27c046

• resolve bug with AMP

  tchaton

  committed
  b10723f

  Copy full SHA for b10723f

• change __repr__

  tchaton

  committed
  8e6f63f

  Copy full SHA for 8e6f63f

• round at -12

  tchaton

  committed
  fe0c876

  Copy full SHA for fe0c876

• udpate

  tchaton

  committed
  0c39f3b

  Copy full SHA for 0c39f3b

• update

  tchaton

  committed
  9ce8ec5

  Copy full SHA for 9ce8ec5

• update

  tchaton

  committed
  9d9e5f7

  Copy full SHA for 9d9e5f7

• remove from horovod

  tchaton

  committed
  193b4ec

  Copy full SHA for 193b4ec

• typo

  tchaton

  committed
  30a352f

  Copy full SHA for 30a352f

• add convert_to_lightning_optimizers in each accelerators

  tchaton

  committed
  0fbe742

  Copy full SHA for 0fbe742

• typo

  tchaton

  committed
  32e4769

  Copy full SHA for 32e4769

• forgot

  tchaton

  committed
  d9bfe2e

  Copy full SHA for d9bfe2e

• forgot a convert_to_lightning_optimizers

  tchaton

  committed
  81dbd40

  Copy full SHA for 81dbd40

• update

  tchaton

  committed
  9de6597

  Copy full SHA for 9de6597

• update

  tchaton

  committed
  b629248

  Copy full SHA for b629248

• update

  tchaton

  committed
  9db4a69

  Copy full SHA for 9db4a69

• increase coverage

  tchaton

  committed
  a97789b

  Copy full SHA for a97789b

• Merge branch 'master' into bugfix/4572_optimizer_step

  tchaton

  authored
  1b63d43

  Copy full SHA for 1b63d43

Commits on Nov 27, 2020

• Merge branch 'master' into bugfix/4572_optimizer_step

  tchaton

  authored
  2240bd7

  Copy full SHA for 2240bd7

• update

  tchaton

  committed
  0f6f50f

  Copy full SHA for 0f6f50f

• Merge branch 'bugfix/4572_optimizer_step' of https://github.com/PyTorchLightning/pytorch-lightning into bugfix/4572_optimizer_step

  tchaton

  committed
  0b3b9d5

  Copy full SHA for 0b3b9d5

• resolve flake8

  tchaton

  committed
  9743193

  Copy full SHA for 9743193

• update

  tchaton

  committed
  9527bd4

  Copy full SHA for 9527bd4

• remove useless code

  tchaton

  committed
  58164de

  Copy full SHA for 58164de

• Merge branch 'master' into bugfix/4572_optimizer_step

  tchaton

  authored
  8c47f28

  Copy full SHA for 8c47f28

• Merge branch 'master' into bugfix/4572_optimizer_step

  tchaton

  authored
  98116af

  Copy full SHA for 98116af

Commits on Nov 28, 2020

• resolve comments + add support for LightningOptimizer base class

  tchaton

  committed
  600d61c

  Copy full SHA for 600d61c

• Merge branch 'bugfix/4572_optimizer_step' of https://github.com/PyTorchLightning/pytorch-lightning into bugfix/4572_optimizer_step

  tchaton

  committed
  5d7b7d0

  Copy full SHA for 5d7b7d0

• resolve flake

  tchaton

  committed
  f96a0d4

  Copy full SHA for f96a0d4

• check optimizer get wrapped back

  tchaton

  committed
  897a400

  Copy full SHA for 897a400

• Merge branch 'master' into bugfix/4572_optimizer_step

  tchaton

  authored
  18e109c

  Copy full SHA for 18e109c

• resolve DDPSharded

  tchaton

  committed
  bda1f4f

  Copy full SHA for bda1f4f

• reduce code

  tchaton

  committed
  8448b93

  Copy full SHA for 8448b93

• lightningoptimizer

  tchaton

  committed
  8b22417

  Copy full SHA for 8b22417

Commits on Nov 29, 2020

• Merge branch 'master' into bugfix/4572_optimizer_step

  tchaton

  authored
  ae8b6f0

  Copy full SHA for ae8b6f0

Commits on Nov 30, 2020

• Merge branch 'master' into bugfix/4572_optimizer_step

  tchaton

  authored
  9fcf871

  Copy full SHA for 9fcf871

• Merge branch 'master' into bugfix/4572_optimizer_step

  tchaton

  authored
  e3343a7

  Copy full SHA for e3343a7

• Update pytorch_lightning/core/optimizer.py

  Show description for a769a2c
  

  tchaton

  and

  carmocca

  authored
  a769a2c

  Copy full SHA for a769a2c

• Update pytorch_lightning/core/lightning.py

  tchaton

  authored
  3fe456b

  Copy full SHA for 3fe456b

• Merge branch 'master' into bugfix/4572_optimizer_step

  tchaton

  authored
  0b6bb75

  Copy full SHA for 0b6bb75

• Merge branch 'master' into bugfix/4572_optimizer_step

  tchaton

  authored
  d599e84

  Copy full SHA for d599e84

• remove reference to step function

  tchaton

  committed
  54f6ff5

  Copy full SHA for 54f6ff5

• Apply suggestions from code review

  Borda

  authored
  d8c6817

  Copy full SHA for d8c6817

• update on comments

  tchaton

  committed
  8224ec6

  Copy full SHA for 8224ec6

• Merge branch 'bugfix/4572_optimizer_step' of https://github.com/PyTorchLightning/pytorch-lightning into bugfix/4572_optimizer_step

  tchaton

  committed
  dc0610d

  Copy full SHA for dc0610d

• resolve

  tchaton

  committed
  44985b1

  Copy full SHA for 44985b1

• Merge branch 'master' into bugfix/4572_optimizer_step

  tchaton

  authored
  09b9ebd

  Copy full SHA for 09b9ebd

• Update CHANGELOG.md

  williamFalcon

  authored
  abff2ac

  Copy full SHA for abff2ac

• add back training_step in apex and native_amp

  tchaton

  committed
  a69881f

  Copy full SHA for a69881f

• rename optimizer_step

  tchaton

  committed
  b231fd8

  Copy full SHA for b231fd8

• Merge branch 'master' into bugfix/4572_optimizer_step

  tchaton

  authored
  c4023dc

  Copy full SHA for c4023dc

• Merge branch 'master' into bugfix/4572_optimizer_step

  SeanNaren

  authored
  53b6921

  Copy full SHA for 53b6921