Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Refactor logging 3/n [v0] #4550

Closed
wants to merge 5 commits into from
Closed

[WIP] Refactor logging 3/n [v0] #4550

wants to merge 5 commits into from

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Nov 6, 2020

What does this PR do?

This PR adds logging within callbacks for evaluation.

Fixes #3813

Before submitting

  • [ x] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • [x ] Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In in short, see following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified; Bugfixes should be including in bug-fix release milestones (m.f.X) and features should be included in (m.X.b) releases.

Did you have fun?

Make sure you had fun coding 🙃

@tchaton tchaton added bug Something isn't working feature Is an improvement or enhancement logger Related to the Loggers priority: 1 Medium priority task labels Nov 6, 2020
@tchaton tchaton added this to the 1.1 milestone Nov 6, 2020
@tchaton tchaton self-assigned this Nov 6, 2020
@pep8speaks
Copy link

pep8speaks commented Nov 6, 2020

Hello @tchaton! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-11-06 12:58:45 UTC

@tchaton tchaton changed the title [WIP] Feat/logging val [WIP] Refactor logging 3/n [v1] Nov 6, 2020
@tchaton tchaton changed the title [WIP] Refactor logging 3/n [v1] [WIP] Refactor logging 3/n [v0] Nov 6, 2020
@tchaton tchaton closed this Nov 6, 2020
@Borda Borda deleted the feat/logging_val branch November 10, 2020 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature Is an improvement or enhancement logger Related to the Loggers priority: 1 Medium priority task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calling module.log(...) within a callback fails
2 participants