Mocking Loggers (part 3d, comet) #3860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @awaelchli! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-10-06 03:07:04 UTC |
|
will rebase after parts a-c are merged |
Codecov Report
@@ Coverage Diff @@
## master #3860 +/- ##
======================================
Coverage 87% 87%
======================================
Files 117 117
Lines 9200 9200
======================================
+ Hits 8044 8045 +1
+ Misses 1156 1155 -1 |
include mkpatch fix test
awaelchli
force-pushed
the
tests/mock-comet-4
branch
from
e33341c to
f14834a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comes after #3859
Part 3 of comet mocking, step by step
the pickling test only works with the real dependency installed. This is the only exception we have to make.
The test only runs if the package is installed, otherwise xfails.
next PR will finish comet tests in loggers/test_all.py