Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

final cleanup for v0.8.0 #2181

Merged
merged 7 commits into from
Jun 18, 2020
Merged

final cleanup for v0.8.0 #2181

merged 7 commits into from
Jun 18, 2020

Conversation

Borda
Copy link
Member

@Borda Borda commented Jun 14, 2020

What does this PR do?

rest final version, add link to docs

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the docs Documentation related label Jun 14, 2020
@Borda Borda added this to the 0.8.0 milestone Jun 14, 2020
@mergify mergify bot requested a review from a team June 14, 2020 11:17
@Borda Borda requested a review from williamFalcon June 14, 2020 11:21
@codecov
Copy link

codecov bot commented Jun 14, 2020

Codecov Report

Merging #2181 into master will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #2181   +/-   ##
======================================
- Coverage      88%     88%   -0%     
======================================
  Files          70      70           
  Lines        5421    5420    -1     
======================================
- Hits         4761    4760    -1     
  Misses        660     660           

@Borda Borda marked this pull request as ready for review June 15, 2020 17:37
@mergify
Copy link
Contributor

mergify bot commented Jun 15, 2020

This pull request is now in conflict... :(

@mergify
Copy link
Contributor

mergify bot commented Jun 15, 2020

This pull request is now in conflict... :(

@jeremyjordan
Copy link
Contributor

There are a number of places that reference changing the epoch count to starting at 0 in v0.8, are we still doing this?

https://github.com/PyTorchLightning/pytorch-lightning/blob/761252be78ba573ad1f5c700190eb89b13e41e99/pytorch_lightning/callbacks/gradient_accumulation_scheduler.py#L60

@williamFalcon
Copy link
Contributor

williamFalcon commented Jun 16, 2020

yes! this should be done. @Borda mind updating?

@Borda
Copy link
Member Author

Borda commented Jun 16, 2020

There are a number of places that reference changing the epoch count to starting at 0 in v0.8, are we still doing this?

https://github.com/PyTorchLightning/pytorch-lightning/blob/761252be78ba573ad1f5c700190eb89b13e41e99/pytorch_lightning/callbacks/gradient_accumulation_scheduler.py#L60

yes! this should be done. @Borda mind updating?

fixing in separate PR #2206

@mergify
Copy link
Contributor

mergify bot commented Jun 16, 2020

This pull request is now in conflict... :(

@mergify
Copy link
Contributor

mergify bot commented Jun 16, 2020

This pull request is now in conflict... :(

@mergify
Copy link
Contributor

mergify bot commented Jun 17, 2020

This pull request is now in conflict... :(

@Borda Borda added feature Is an improvement or enhancement priority: 0 High priority task labels Jun 18, 2020
@Borda Borda mentioned this pull request Jun 18, 2020
5 tasks
@williamFalcon williamFalcon merged commit a2d3ee8 into master Jun 18, 2020
@Borda Borda deleted the release/0.8.0 branch June 18, 2020 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related feature Is an improvement or enhancement priority: 0 High priority task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants