New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker: fix setting tags #20504

Merged

lantiga merged 9 commits into master from docker/tags

Dec 20, 2024

Member

Borda commented Dec 19, 2024 •

edited by github-actions bot

Loading

What does this PR do?

the configuration was updated and its logic was sensitive to miss updates with new versions

Before submitting

Was this discussed/agreed via a GitHub issue? (not for typos and docs)
Did you read the contributor guideline, Pull Request section?
Did you make sure your PR does only one thing, instead of bundling different changes together?
Did you make sure to update the documentation with your changes? (if necessary)
Did you write any new necessary tests? (not for typos and docs)
Did you verify new and existing tests pass locally with your changes?
Did you list all the breaking changes introduced by this pull request?
Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist

Is this pull request ready for review? (if not, please submit in draft mode)
Check that all items from Before submitting are resolved
Make sure the title is self-explanatory and the description concisely explains the PR
Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--20504.org.readthedocs.build/en/20504/


          docker: fix setting tags

a548187

Borda requested review from lantiga, tchaton, justusschock and ethanwharris as code owners

December 19, 2024 09:11

github-actions bot added ci dockers labels

pre-commit-ci bot and others added 2 commits

December 19, 2024 09:12


          [pre-commit.ci] auto fixes from pre-commit.com hooks

ef9661b

for more information, see https://pre-commit.ci


          pip install

e59763e

Contributor

github-actions bot commented Dec 19, 2024 •

edited

Loading

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow

Check ID	Status
pl-cpu (macOS-14, lightning, 3.9, 2.1, oldest)	success	✅
pl-cpu (macOS-14, lightning, 3.10, 2.1)	success	✅
pl-cpu (macOS-14, lightning, 3.11, 2.2.2)	success	✅
pl-cpu (macOS-14, lightning, 3.11, 2.3)	success	✅
pl-cpu (macOS-14, lightning, 3.12, 2.4.1)	success	✅
pl-cpu (macOS-14, lightning, 3.12, 2.5.1)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.9, 2.1, oldest)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.1)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.11, 2.2.2)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.11, 2.3)	success	✅
pl-cpu (ubuntu-22.04, lightning, 3.12, 2.4.1)	success	✅
pl-cpu (ubuntu-22.04, lightning, 3.12, 2.5.1)	success	✅
pl-cpu (windows-2022, lightning, 3.9, 2.1, oldest)	success	✅
pl-cpu (windows-2022, lightning, 3.10, 2.1)	success	✅
pl-cpu (windows-2022, lightning, 3.11, 2.2.2)	success	✅
pl-cpu (windows-2022, lightning, 3.11, 2.3)	success	✅
pl-cpu (windows-2022, lightning, 3.12, 2.4.1)	success	✅
pl-cpu (windows-2022, lightning, 3.12, 2.5.1)	success	✅
pl-cpu (macOS-14, pytorch, 3.9, 2.1)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.9, 2.1)	success	✅
pl-cpu (windows-2022, pytorch, 3.9, 2.1)	success	✅
pl-cpu (macOS-14, pytorch, 3.12, 2.5.1)	success	✅
pl-cpu (ubuntu-22.04, pytorch, 3.12, 2.5.1)	success	✅
pl-cpu (windows-2022, pytorch, 3.12, 2.5.1)	success	✅

These checks are required after the changes to .actions/assistant.py.

🟢 pytorch_lightning: Azure GPU

Check ID	Status
pytorch-lightning (GPUs) (testing Lightning \| latest)	success	✅
pytorch-lightning (GPUs) (testing PyTorch \| latest)	success	✅

These checks are required after the changes to .actions/assistant.py.

🟢 pytorch_lightning: Docs

Check ID	Status
docs-make (pytorch, doctest)	success	✅
docs-make (pytorch, html)	success	✅

These checks are required after the changes to .actions/assistant.py.

🟢 pytorch_lightning: Docker

Check ID	Status
build-cuda (3.10, 2.1.2, 12.1.1)	success	✅
build-cuda (3.11, 2.2.2, 12.1.1)	success	✅
build-cuda (3.11, 2.3.1, 12.1.1)	success	✅
build-cuda (3.11, 2.4.1, 12.1.1)	success	✅
build-cuda (3.12, 2.5.1, 12.1.1)	success	✅
build-pl (3.10, 2.1, 12.1.1)	success	✅
build-pl (3.11, 2.2, 12.1.1)	success	✅
build-pl (3.11, 2.3, 12.1.1)	success	✅
build-pl (3.11, 2.4, 12.1.1)	success	✅
build-pl (3.12, 2.5, 12.1.1, true)	success	✅

These checks are required after the changes to .actions/assistant.py, .github/workflows/docker-build.yml.

🟢 lightning_fabric: CPU workflow

Check ID	Status
fabric-cpu (macOS-14, lightning, 3.9, 2.1, oldest)	success	✅
fabric-cpu (macOS-14, lightning, 3.10, 2.1)	success	✅
fabric-cpu (macOS-14, lightning, 3.11, 2.2.2)	success	✅
fabric-cpu (macOS-14, lightning, 3.11, 2.3)	success	✅
fabric-cpu (macOS-14, lightning, 3.12, 2.4.1)	success	✅
fabric-cpu (macOS-14, lightning, 3.12, 2.5.1)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.9, 2.1, oldest)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.10, 2.1)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.11, 2.2.2)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.11, 2.3)	success	✅
fabric-cpu (ubuntu-22.04, lightning, 3.12, 2.4.1)	success	✅
fabric-cpu (ubuntu-22.04, lightning, 3.12, 2.5.1)	success	✅
fabric-cpu (windows-2022, lightning, 3.9, 2.1, oldest)	success	✅
fabric-cpu (windows-2022, lightning, 3.10, 2.1)	success	✅
fabric-cpu (windows-2022, lightning, 3.11, 2.2.2)	success	✅
fabric-cpu (windows-2022, lightning, 3.11, 2.3)	success	✅
fabric-cpu (windows-2022, lightning, 3.12, 2.4.1)	success	✅
fabric-cpu (windows-2022, lightning, 3.12, 2.5.1)	success	✅
fabric-cpu (macOS-14, fabric, 3.9, 2.1)	success	✅
fabric-cpu (ubuntu-20.04, fabric, 3.9, 2.1)	success	✅
fabric-cpu (windows-2022, fabric, 3.9, 2.1)	success	✅
fabric-cpu (macOS-14, fabric, 3.12, 2.5.1)	success	✅
fabric-cpu (ubuntu-22.04, fabric, 3.12, 2.5.1)	success	✅
fabric-cpu (windows-2022, fabric, 3.12, 2.5.1)	success	✅

These checks are required after the changes to .actions/assistant.py.

🟢 lightning_fabric: Azure GPU

Check ID	Status
lightning-fabric (GPUs) (testing Fabric \| latest)	success	✅
lightning-fabric (GPUs) (testing Lightning \| latest)	success	✅

These checks are required after the changes to .actions/assistant.py.

🟢 mypy

Check ID	Status
mypy	success	✅

These checks are required after the changes to .actions/assistant.py.

🟢 install

Check ID	Status
install-pkg (ubuntu-22.04, fabric, 3.9)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.11)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.9)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.11)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.9)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.11)	success	✅
install-pkg (ubuntu-22.04, notset, 3.9)	success	✅
install-pkg (ubuntu-22.04, notset, 3.11)	success	✅
install-pkg (macOS-14, fabric, 3.9)	success	✅
install-pkg (macOS-14, fabric, 3.11)	success	✅
install-pkg (macOS-14, pytorch, 3.9)	success	✅
install-pkg (macOS-14, pytorch, 3.11)	success	✅
install-pkg (macOS-14, lightning, 3.9)	success	✅
install-pkg (macOS-14, lightning, 3.11)	success	✅
install-pkg (macOS-14, notset, 3.9)	success	✅
install-pkg (macOS-14, notset, 3.11)	success	✅
install-pkg (windows-2022, fabric, 3.9)	success	✅
install-pkg (windows-2022, fabric, 3.11)	success	✅
install-pkg (windows-2022, pytorch, 3.9)	success	✅
install-pkg (windows-2022, pytorch, 3.11)	success	✅
install-pkg (windows-2022, lightning, 3.9)	success	✅
install-pkg (windows-2022, lightning, 3.11)	success	✅
install-pkg (windows-2022, notset, 3.9)	success	✅
install-pkg (windows-2022, notset, 3.11)	success	✅

These checks are required after the changes to .actions/assistant.py.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.


          Merge branch 'docker/tags' of https://github.com/Lightning-AI/lightning…

d07a3f7

… into docker/tags

codecov bot commented Dec 19, 2024 •

edited

Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88%. Comparing base (f9babd1) to head (cee72ff).
Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #20504   +/-   ##
=======================================
  Coverage      88%      88%           
=======================================
  Files         267      267           
  Lines       23386    23386           
=======================================
  Hits        20487    20487           
  Misses       2899     2899

cmd

de8a077

Borda force-pushed the docker/tags branch from 969f993 to de8a077 Compare

December 19, 2024 09:38

Borda added 2 commits

December 19, 2024 18:40


          latest

462197a


          print

a58d141

Borda changed the title ~~docker: fix setting tags [wip]~~ docker: fix setting tags

Borda and others added 2 commits

December 20, 2024 02:02


          Merge branch 'master' into docker/tags

a9e3b4a


          cuda 12.1.1

cee72ff

lantiga approved these changes

View reviewed changes

lantiga merged commit c45c3c9 into master

117 of 122 checks passed

lantiga deleted the docker/tags branch

December 20, 2024 09:05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lantiga lantiga approved these changes

tchaton Awaiting requested review from tchaton tchaton is a code owner

justusschock Awaiting requested review from justusschock justusschock is a code owner

ethanwharris Awaiting requested review from ethanwharris ethanwharris is a code owner

Labels