Allow callbacks to be restored not just during training #20403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chualanagit
requested review from
lantiga,
Borda,
tchaton and
justusschock
as code owners
added 2 commits
November 6, 2024 22:28
chualanagit
force-pushed
the
chualan/restore-callback-status-when-predicting
branch
from
d039633 to
7ed08ec
Compare
for more information, see https://pre-commit.ci
chualanagit
changed the title
|
hey @chualanagit thanks for the contribution! looks reasonable to me, can you please add an example of usage to the linked issue? |
lantiga
changed the title
will do, thanks for the review, I'm still doing some testing, will get back to you all here soon! |
lantiga
added
the
waiting on author
lantiga
approved these changes
Nov 14, 2024
|
Looks good, merging! Thanks for the PR @chualanagit |
MrWhatZitToYaa
pushed a commit
to MrWhatZitToYaa/pytorch-lightning
that referenced
this pull request
Nov 20, 2024
…#20403) * Allow callbacks to be restored not just during training * add test case * test test case failure * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix test case --------- Co-authored-by: Alan Chu <alanchu@Alans-Air.lan> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Luca Antiga <luca.antiga@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #20137
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--20403.org.readthedocs.build/en/20403/