-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add device property to lazy load functionality #20183
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-vi
requested review from
lantiga,
Borda,
tchaton,
awaelchli and
justusschock
as code owners
August 9, 2024 07:50
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20183 +/- ##
=======================================
Coverage 89% 89%
=======================================
Files 267 267
Lines 23079 23082 +3
=======================================
+ Hits 20580 20583 +3
Misses 2499 2499 |
Borda
approved these changes
Aug 9, 2024
awaelchli
approved these changes
Aug 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Tom 🎉
awaelchli
changed the title
a bit more lazy load functionality
Add device property to lazy load functionality
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the .device property and the method .to to NotYetLoaded tensors produced by lazy loading.
The two would be convenient to have for Thunder.
📚 Documentation preview 📚: https://pytorch-lightning--20183.org.readthedocs.build/en/20183/
cc @Borda @carmocca @justusschock @awaelchli